Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2519843002: Update ResourceResponse::encodedDataLength when response is completed (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years, 1 month ago
Reviewers:
hiroshige, kinuko, tzik
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tyoshino+watch_chromium.org, jam, Yoav Weiss, loading-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, blink-reviews-api_chromium.org, allada
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ResourceResponse::encodedDataLength when response is completed This CL updates ResourceResponse::encodedDataLength when a response is completed either successfully or unsuccessfully. This is a preliminary change to stop dispatching encoded_data_length on each data chunk arrival. https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit# BUG=666216 Committed: https://crrev.com/ef64829b35e92bd18842e56b7fe7bd59bc007767 Cr-Commit-Position: refs/heads/master@{#433889}

Patch Set 1 : fix #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : Update ResourceResponse::encodedDataLength when response is completed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLLoaderTestDelegate.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderClient.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderTestDelegate.h View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 43 (32 generated)
yhirano
hiroshige@, tzik@: PTAL cc: allada@ fyi
4 years, 1 month ago (2016-11-22 01:39:24 UTC) #18
kinuko
lgtm once/if other reviewers are happy
4 years, 1 month ago (2016-11-22 03:35:46 UTC) #19
tzik
lgtm
4 years, 1 month ago (2016-11-22 06:53:58 UTC) #20
hiroshige
https://codereview.chromium.org/2519843002/diff/60001/third_party/WebKit/Source/core/fetch/Resource.h File third_party/WebKit/Source/core/fetch/Resource.h (right): https://codereview.chromium.org/2519843002/diff/60001/third_party/WebKit/Source/core/fetch/Resource.h#newcode303 third_party/WebKit/Source/core/fetch/Resource.h:303: void setEncodedDataLength(int value) { Shouldn't this |int64_t value|?
4 years, 1 month ago (2016-11-22 08:26:07 UTC) #22
yhirano
https://codereview.chromium.org/2519843002/diff/60001/third_party/WebKit/Source/core/fetch/Resource.h File third_party/WebKit/Source/core/fetch/Resource.h (right): https://codereview.chromium.org/2519843002/diff/60001/third_party/WebKit/Source/core/fetch/Resource.h#newcode303 third_party/WebKit/Source/core/fetch/Resource.h:303: void setEncodedDataLength(int value) { On 2016/11/22 08:26:06, hiroshige wrote: ...
4 years, 1 month ago (2016-11-22 08:43:42 UTC) #25
hiroshige
lgtm.
4 years, 1 month ago (2016-11-22 11:01:24 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519843002/100001
4 years, 1 month ago (2016-11-22 11:09:44 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/336867)
4 years, 1 month ago (2016-11-22 14:56:39 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519843002/100001
4 years, 1 month ago (2016-11-22 15:52:42 UTC) #38
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 1 month ago (2016-11-22 17:09:12 UTC) #41
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:12:18 UTC) #43
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ef64829b35e92bd18842e56b7fe7bd59bc007767
Cr-Commit-Position: refs/heads/master@{#433889}

Powered by Google App Engine
This is Rietveld 408576698