Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2521503002: Rename ResourceResponse::addToEncodedDataSize() to setEncodedDataSize() (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ResourceResponse::addToEncodedDataSize() to setEncodedDataSize() ResourceResponse::addToEncodedDataSize is used only on a ResourceResponse whose encodedDataLength is 0. I'm planning to update the value at the response completion timing and setEncodedDataSize is easier to use / understand. BUG=666216 Committed: https://crrev.com/e0d49be76df5f71f17cf8aaf77772f386e1edae3 Cr-Commit-Position: refs/heads/master@{#433742}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M content/child/web_url_loader_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (25 generated)
yhirano
4 years, 1 month ago (2016-11-21 11:45:53 UTC) #8
hiroshige
lgtm. CL title: How about "Rename addToEncodedDataSize() to setEncodedDataSize()"?
4 years, 1 month ago (2016-11-21 11:57:44 UTC) #9
yhirano
On 2016/11/21 11:57:44, hiroshige wrote: > lgtm. > > CL title: > How about "Rename ...
4 years, 1 month ago (2016-11-21 12:00:38 UTC) #11
yhirano
+jochen@ for OWNER review.
4 years, 1 month ago (2016-11-21 12:00:56 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-21 12:02:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521503002/20001
4 years, 1 month ago (2016-11-21 12:10:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521503002/40001
4 years, 1 month ago (2016-11-21 12:23:20 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276833)
4 years, 1 month ago (2016-11-21 16:24:26 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521503002/40001
4 years, 1 month ago (2016-11-22 01:31:55 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-22 02:09:47 UTC) #34
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:16:25 UTC) #36
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0d49be76df5f71f17cf8aaf77772f386e1edae3
Cr-Commit-Position: refs/heads/master@{#433742}

Powered by Google App Engine
This is Rietveld 408576698