Make CPDF_Stream() take unique_ptr's to its dictionary.

Make CPDF_Stream() take unique_ptr's to its dictionary.

Committed: https://pdfium.googlesource.com/pdfium/+/9e05ee1e7bfb74d56d69620ad1e72b03e29b9237

[Tom Sepez, 2016-11-18 19:58:39]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-11-18 19:58:39]

Lei, Dan, next one.

[Lei Zhang, 2016-11-18 23:50:34]

lgtm

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/page/cpdf_imag...
File core/fpdfapi/page/cpdf_image.cpp (right):

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/page/cpdf_imag...
core/fpdfapi/page/cpdf_image.cpp:289: ->NewIndirect<CPDF_Stream>(
Can we do the NewIndirect() call separately?

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/parser/cpdf_st...
File core/fpdfapi/parser/cpdf_stream.h (right):

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/parser/cpdf_st...
core/fpdfapi/parser/cpdf_stream.h:21: // Takes ownership of |pData| and |pDict|.
Update comment.

https://codereview.chromium.org/2520493002/diff/1/fpdfsdk/fpdfsave.cpp
File fpdfsdk/fpdfsave.cpp (right):

https://codereview.chromium.org/2520493002/diff/1/fpdfsdk/fpdfsave.cpp#newcod...
fpdfsdk/fpdfsave.cpp:204: if (pFormStream)
curly braces, like line 180.

[Tom Sepez, 2016-11-19 00:05:16]

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/page/cpdf_imag...
File core/fpdfapi/page/cpdf_image.cpp (right):

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/page/cpdf_imag...
core/fpdfapi/page/cpdf_image.cpp:289: ->NewIndirect<CPDF_Stream>(
On 2016/11/18 23:50:34, Lei Zhang (Mostly OOO) wrote:
> Can we do the NewIndirect() call separately?

Done.  That looks much better now.

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/parser/cpdf_st...
File core/fpdfapi/parser/cpdf_stream.h (right):

https://codereview.chromium.org/2520493002/diff/1/core/fpdfapi/parser/cpdf_st...
core/fpdfapi/parser/cpdf_stream.h:21: // Takes ownership of |pData| and |pDict|.
On 2016/11/18 23:50:34, Lei Zhang (Mostly OOO) wrote:
> Update comment.

Done. I assume you meant removing the "and |pDict|" so we don't tell
you something you already know from the code.

https://codereview.chromium.org/2520493002/diff/1/fpdfsdk/fpdfsave.cpp
File fpdfsdk/fpdfsave.cpp (right):

https://codereview.chromium.org/2520493002/diff/1/fpdfsdk/fpdfsave.cpp#newcod...
fpdfsdk/fpdfsave.cpp:204: if (pFormStream)
On 2016/11/18 23:50:34, Lei Zhang (Mostly OOO) wrote:
> curly braces, like line 180.

Done.

[Lei Zhang, 2016-11-20 08:53:24]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 08:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 08:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 08:59:56]

Dry run: Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2877)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Lei Zhang, 2016-11-21 19:29:39]

This just needs a bit of rebasing, but otherwise should be safe to land.

[Tom Sepez, 2016-11-21 20:13:13]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 20:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:38:20]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-21 21:18:46]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-11-21 21:18:46]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2520493002/#ps40001
(title: "rebase, lint, fix new test.")

[commit-bot: I haz the power, 2016-11-21 21:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:19:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479763126441780,
"parent_rev": "aa3922dd713d480229408f3a0813b7dab9e8fd78", "commit_rev":
"9e05ee1e7bfb74d56d69620ad1e72b03e29b9237"}

[commit-bot: I haz the power, 2016-11-21 21:19:13]

Description was changed from

==========
Make CPDF_Stream() take unique_ptr's to its dictionary.
==========

to

==========
Make CPDF_Stream() take unique_ptr's to its dictionary.

Committed:
https://pdfium.googlesource.com/pdfium/+/9e05ee1e7bfb74d56d69620ad1e72b03e29b...
==========

[commit-bot: I haz the power, 2016-11-21 21:19:14]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/9e05ee1e7bfb74d56d69620ad1e72b03e29b...