core/fpdfapi/page/cpdf_streamparser.cpp - Issue 2520493002: Make CPDF_Stream() take unique_ptr's to its dictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_streamparser.cpp

Issue 2520493002: Make CPDF_Stream() take unique_ptr's to its dictionary. (Closed)

Patch Set: rebase, lint, fix new test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_streamparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamparser.cpp b/core/fpdfapi/page/cpdf_streamparser.cpp

index 6b4a3622575c5888108994082fb5c308b6a39309..f271e58d78e36e2a8dc4f74a6c40634c7020fd79 100644

--- a/core/fpdfapi/page/cpdf_streamparser.cpp

+++ b/core/fpdfapi/page/cpdf_streamparser.cpp

@@ -233,7 +233,7 @@ CPDF_Stream* CPDF_StreamParser::ReadInlineStream(CPDF_Document* pDoc,

m_Pos += dwStreamSize;

}

pDict->SetNewFor<CPDF_Number>("Length", (int)dwStreamSize);

- return new CPDF_Stream(pData, dwStreamSize, pDict);

+ return new CPDF_Stream(pData, dwStreamSize, pdfium::WrapUnique(pDict));

}

CPDF_StreamParser::SyntaxType CPDF_StreamParser::ParseNextElement() {

« no previous file with comments | « core/fpdfapi/page/cpdf_image.cpp ('k') | core/fpdfapi/parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »