Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: xfa/fxfa/app/xfa_ffapp_unittest.cpp

Issue 2520493002: Make CPDF_Stream() take unique_ptr's to its dictionary. (Closed)
Patch Set: rebase, lint, fix new test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/fpdfsave.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "xfa/fxfa/xfa_ffapp.h" 5 #include "xfa/fxfa/xfa_ffapp.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "core/fpdfapi/parser/cpdf_dictionary.h" 10 #include "core/fpdfapi/parser/cpdf_dictionary.h"
(...skipping 28 matching lines...) Expand all
39 } 39 }
40 40
41 TEST(CXFAFileRead, NormalStreams) { 41 TEST(CXFAFileRead, NormalStreams) {
42 std::vector<CPDF_Stream*> streams; 42 std::vector<CPDF_Stream*> streams;
43 std::unique_ptr<CPDF_Stream> stream1 = pdfium::MakeUnique<CPDF_Stream>(); 43 std::unique_ptr<CPDF_Stream> stream1 = pdfium::MakeUnique<CPDF_Stream>();
44 std::unique_ptr<CPDF_Stream> stream2 = pdfium::MakeUnique<CPDF_Stream>(); 44 std::unique_ptr<CPDF_Stream> stream2 = pdfium::MakeUnique<CPDF_Stream>();
45 std::unique_ptr<CPDF_Stream> stream3 = pdfium::MakeUnique<CPDF_Stream>(); 45 std::unique_ptr<CPDF_Stream> stream3 = pdfium::MakeUnique<CPDF_Stream>();
46 46
47 // 16 chars total. 47 // 16 chars total.
48 stream1->InitStream(reinterpret_cast<const uint8_t*>("one t"), 5, 48 stream1->InitStream(reinterpret_cast<const uint8_t*>("one t"), 5,
49 new CPDF_Dictionary()); 49 pdfium::MakeUnique<CPDF_Dictionary>());
50 stream2->InitStream(reinterpret_cast<const uint8_t*>("wo "), 3, 50 stream2->InitStream(reinterpret_cast<const uint8_t*>("wo "), 3,
51 new CPDF_Dictionary()); 51 pdfium::MakeUnique<CPDF_Dictionary>());
52 stream3->InitStream(reinterpret_cast<const uint8_t*>("three!!!"), 8, 52 stream3->InitStream(reinterpret_cast<const uint8_t*>("three!!!"), 8,
53 new CPDF_Dictionary()); 53 pdfium::MakeUnique<CPDF_Dictionary>());
54 54
55 streams.push_back(stream1.get()); 55 streams.push_back(stream1.get());
56 streams.push_back(stream2.get()); 56 streams.push_back(stream2.get());
57 streams.push_back(stream3.get()); 57 streams.push_back(stream3.get());
58 UniqueFileRead fileread(new CXFA_FileRead(streams)); 58 UniqueFileRead fileread(new CXFA_FileRead(streams));
59 59
60 uint8_t output_buffer[16]; 60 uint8_t output_buffer[16];
61 memset(output_buffer, 0xbd, sizeof(output_buffer)); 61 memset(output_buffer, 0xbd, sizeof(output_buffer));
62 EXPECT_TRUE(fileread->ReadBlock(output_buffer, 0, 0)); 62 EXPECT_TRUE(fileread->ReadBlock(output_buffer, 0, 0));
63 EXPECT_EQ(0xbd, output_buffer[0]); 63 EXPECT_EQ(0xbd, output_buffer[0]);
(...skipping 14 matching lines...) Expand all
78 memset(output_buffer, 0xbd, sizeof(output_buffer)); 78 memset(output_buffer, 0xbd, sizeof(output_buffer));
79 EXPECT_TRUE(fileread->ReadBlock(output_buffer, 2, 10)); 79 EXPECT_TRUE(fileread->ReadBlock(output_buffer, 2, 10));
80 EXPECT_EQ(0, memcmp(output_buffer, "e two thre", 10)); 80 EXPECT_EQ(0, memcmp(output_buffer, "e two thre", 10));
81 EXPECT_EQ(0xbd, output_buffer[11]); 81 EXPECT_EQ(0xbd, output_buffer[11]);
82 82
83 memset(output_buffer, 0xbd, sizeof(output_buffer)); 83 memset(output_buffer, 0xbd, sizeof(output_buffer));
84 EXPECT_FALSE(fileread->ReadBlock(output_buffer, 1, sizeof(output_buffer))); 84 EXPECT_FALSE(fileread->ReadBlock(output_buffer, 1, sizeof(output_buffer)));
85 EXPECT_EQ(0, memcmp(output_buffer, "ne two three!!!", 15)); 85 EXPECT_EQ(0, memcmp(output_buffer, "ne two three!!!", 15));
86 EXPECT_EQ(0xbd, output_buffer[15]); 86 EXPECT_EQ(0xbd, output_buffer[15]);
87 } 87 }
OLDNEW
« no previous file with comments | « fpdfsdk/fpdfsave.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698