Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2520443002: Make AllDismissedItem and Footer optional leaves. (Closed)

Created:
4 years, 1 month ago by Bernhard Bauer
Modified:
4 years, 1 month ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AllDismissedItem and Footer optional leaves. BUG=616090 Committed: https://crrev.com/e4fa733a47d0a1a75605c2427bfa18bee6aa9fd4 Cr-Commit-Position: refs/heads/master@{#433568}

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : comments #

Messages

Total messages: 15 (10 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 1 month ago (2016-11-21 14:35:14 UTC) #8
Michael van Ouwerkerk
That's neat :-) lgtm
4 years, 1 month ago (2016-11-21 16:14:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520443002/40001
4 years, 1 month ago (2016-11-21 16:18:52 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 16:53:22 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:57:04 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4fa733a47d0a1a75605c2427bfa18bee6aa9fd4
Cr-Commit-Position: refs/heads/master@{#433568}

Powered by Google App Engine
This is Rietveld 408576698