chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java - Issue 2520443002: Make AllDismissedItem and Footer optional leaves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2520443002: Make AllDismissedItem and Footer optional leaves. (Closed)

Patch Set: comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

index 476980470ac5a0e0f50ccdb2d344406a4a3cfc2c..acb5ed2f8be35fd7e73f24ec7cdd126040586c4e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

@@ -19,6 +19,9 @@ public abstract class InnerNode extends ChildNode implements NodeParent {

protected abstract List<TreeNode> getChildren();

private int getChildIndexForPosition(int position) {

+ if (position < 0) {

+ throw new IndexOutOfBoundsException(Integer.toString(position));

+ }

List<TreeNode> children = getChildren();

int numItems = 0;

int numChildren = children.size();