Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2515713002: Move fetching new suggestions for all categories to the SuggestionsSource. (Closed)

Created:
4 years, 1 month ago by Bernhard Bauer
Modified:
4 years, 1 month ago
Reviewers:
dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move fetching new suggestions for all categories to the SuggestionsSource. This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource, which can be more easily mocked in tests. BUG=616090 Committed: https://crrev.com/6cf39f0878de2cc72b7631aa9d5a58f2310495a4 Cr-Commit-Position: refs/heads/master@{#433513}

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : x #

Messages

Total messages: 21 (15 generated)
Bernhard Bauer
Please review.
4 years, 1 month ago (2016-11-18 17:15:37 UTC) #7
dgn
lgtm, with a nit: Maybe rename it "fetchRemoteSuggestions" to make it clear that it triggers ...
4 years, 1 month ago (2016-11-18 18:20:49 UTC) #8
Bernhard Bauer
On 2016/11/18 18:20:49, dgn wrote: > lgtm, with a nit: Maybe rename it "fetchRemoteSuggestions" to ...
4 years, 1 month ago (2016-11-21 11:13:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515713002/40001
4 years, 1 month ago (2016-11-21 11:13:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 11:47:57 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 11:50:41 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6cf39f0878de2cc72b7631aa9d5a58f2310495a4
Cr-Commit-Position: refs/heads/master@{#433513}

Powered by Google App Engine
This is Rietveld 408576698