Move fetching new suggestions for all categories to the SuggestionsSource.

Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
Committed: https://crrev.com/6cf39f0878de2cc72b7631aa9d5a58f2310495a4
Cr-Commit-Position: refs/heads/master@{#433513}

[Bernhard Bauer, 2016-11-18 15:54:29]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 15:54:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 16:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 16:39:11]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-11-18 17:15:17]

Description was changed from

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor or SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
==========

to

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
==========

[Bernhard Bauer, 2016-11-18 17:15:37]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2016-11-18 17:15:37]

Please review.

[dgn, 2016-11-18 18:20:49]

lgtm, with a nit: Maybe rename it "fetchRemoteSuggestions" to make it clear that
it triggers the on all remote suggestions? (i.e. not a single category and does
not do anything to local categories.)

[Bernhard Bauer, 2016-11-21 09:44:32]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 09:44:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 10:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 10:12:59]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-11-21 11:13:03]

On 2016/11/18 18:20:49, dgn wrote:
> lgtm, with a nit: Maybe rename it "fetchRemoteSuggestions" to make it clear
that
> it triggers the on all remote suggestions? (i.e. not a single category and
does
> not do anything to local categories.)

Good idea! Done.

[Bernhard Bauer, 2016-11-21 11:13:18]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-11-21 11:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org
Link to the patchset: https://codereview.chromium.org/2515713002/#ps40001
(title: "x")

[commit-bot: I haz the power, 2016-11-21 11:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 11:47:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479726798755480,
"parent_rev": ["7f65812952cc583ca78b77f1a8729b4bdd65cdb5", null], "commit_rev":
["ca10751e2b28a706ee8d7109b2c09d65d3944979", null]}

[commit-bot: I haz the power, 2016-11-21 11:47:57]

Description was changed from

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
==========

to

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
==========

[commit-bot: I haz the power, 2016-11-21 11:47:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-21 11:50:40]

Description was changed from

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090
==========

to

==========
Move fetching new suggestions for all categories to the SuggestionsSource.

This removes dependencies on NewTabPageAdapter in favor of SuggestionsSource,
which can be more easily mocked in tests.

BUG=616090

Committed: https://crrev.com/6cf39f0878de2cc72b7631aa9d5a58f2310495a4
Cr-Commit-Position: refs/heads/master@{#433513}
==========

[commit-bot: I haz the power, 2016-11-21 11:50:41]

Patchset 3 (id:??) landed as
https://crrev.com/6cf39f0878de2cc72b7631aa9d5a58f2310495a4
Cr-Commit-Position: refs/heads/master@{#433513}