Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2520273002: binding: Makes Dictionary::hasProperty rethrow an exception. (Closed)

Created:
4 years, 1 month ago by Yuki
Modified:
4 years ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes Dictionary::hasProperty rethrow an exception. Lets Dictionary::hasProperty rethrow an exception if any up to the call sites. BUG=666661 Committed: https://crrev.com/6a1fcb941b70b0910e84a782a68dc79e0a022774 Cr-Commit-Position: refs/heads/master@{#434444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 1 chunk +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
Yuki
Could you guys review this CL?
4 years, 1 month ago (2016-11-22 12:11:09 UTC) #6
haraken
LGTM
4 years, 1 month ago (2016-11-22 14:12:01 UTC) #7
bashi
lgtm
4 years ago (2016-11-22 21:28:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520273002/1
4 years ago (2016-11-24 07:06:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 09:07:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520273002/1
4 years ago (2016-11-24 10:06:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 12:07:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520273002/1
4 years ago (2016-11-25 05:55:17 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 07:14:08 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-25 07:15:52 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a1fcb941b70b0910e84a782a68dc79e0a022774
Cr-Commit-Position: refs/heads/master@{#434444}

Powered by Google App Engine
This is Rietveld 408576698