binding: Makes Dictionary::hasProperty rethrow an exception.

third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 39 matching lines @@
   if (dictionaryObject->IsObject()) {
     m_valueType = ValueType::Object;
     m_dictionaryObject = dictionaryObject.As<v8::Object>();
     return;
   }
 
   exceptionState.throwTypeError(
       "The dictionary provided is neither undefined, null nor an Object.");
 }
 
-bool Dictionary::hasProperty(const StringView& key) const {
+bool Dictionary::hasProperty(const StringView& key,
+                             ExceptionState& exceptionState) const {
   if (m_dictionaryObject.IsEmpty())
     return false;
 
-  // TODO(bashi,yukishiino): Should rethrow the exception.
-  // Has() on a revoked proxy will throw an exception.
-  // http://crbug.com/666661
-  return v8CallBoolean(
-      m_dictionaryObject->Has(v8Context(), v8String(m_isolate, key)));
+  v8::TryCatch tryCatch(m_isolate);
+  bool hasKey = false;
+  if (!m_dictionaryObject->Has(v8Context(), v8String(m_isolate, key))
+           .To(&hasKey)) {
+    exceptionState.rethrowV8Exception(tryCatch.Exception());
+    return false;
+  }
+
+  return hasKey;
 }
 
 DictionaryIterator Dictionary::getIterator(
     ExecutionContext* executionContext) const {
   v8::Local<v8::Value> iteratorGetter;
   if (!getInternal(v8::Symbol::GetIterator(m_isolate), iteratorGetter) ||
       !iteratorGetter->IsFunction())
     return nullptr;
   v8::Local<v8::Value> iterator;
   if (!v8Call(V8ScriptRunner::callFunction(
@@ skipping 97 matching lines @@
     if (!v8CallBoolean(m_dictionaryObject->Has(v8Context(), key)))
       continue;
     TOSTRING_DEFAULT(V8StringResource<>, stringKey, key, false);
     names.append(stringKey);
   }
 
   return true;
 }
 
 }  // namespace blink