Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2520273002: binding: Makes Dictionary::hasProperty rethrow an exception. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index c58565ae8451b22e0c1cf7e6c2920d0058897b31..2bc5aaa750f8ca1a70b2e71604aeccb131bfed48 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -850,7 +850,7 @@ ScriptPromise RTCPeerConnection::generateCertificate(
Nullable<DOMTimeStamp> expires;
if (keygenAlgorithm.isDictionary()) {
Dictionary keygenAlgorithmDict = keygenAlgorithm.getAsDictionary();
- if (keygenAlgorithmDict.hasProperty("expires")) {
+ if (keygenAlgorithmDict.hasProperty("expires", exceptionState)) {
v8::Local<v8::Value> expiresValue;
keygenAlgorithmDict.get("expires", expiresValue);
if (expiresValue->IsNumber()) {
@@ -864,6 +864,9 @@ ScriptPromise RTCPeerConnection::generateCertificate(
}
}
}
+ if (exceptionState.hadException()) {
+ return ScriptPromise();
+ }
// Convert from WebCrypto representation to recognized WebRTCKeyParams. WebRTC
// supports a small subset of what are valid AlgorithmIdentifiers.
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698