Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 252023005: Revert 266470 "Implement async touchmove dispatch during scroll" (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266470 "Implement async touchmove dispatch during scroll" valgrind reports uninitialized memory usage: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/33440/steps/memory%20test%3A%20content/logs/AD4CE3561F03B37F fun:_ZN7content15TouchEventQueue25SendTouchEventImmediatelyERKNS_20EventWithLatencyInfoIN5blink13WebTouchEventEEE fun:_ZN7content15TouchEventQueue26ForwardNextEventToRendererEv fun:_ZN7content15TouchEventQueue10QueueEventERKNS_20EventWithLatencyInfoIN5blink13WebTouchEventEEE fun:_ZN7content19TouchEventQueueTest14SendTouchEventERKN5blink13WebTouchEventE fun:_ZN7content19TouchEventQueueTest14SendTouchEventEv fun:_ZN7content19TouchEventQueueTest15PressTouchPointEff fun:_ZN7content30TouchEventQueueTest_Basic_Test8TestBodyEv http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/33440/steps/memory%20test%3A%20content/logs/383BD397F91FBC46 fun:_ZN7content15TouchEventQueue25SendTouchEventImmediatelyERKNS_20EventWithLatencyInfoIN5blink13WebTouchEventEEE fun:_ZN7content15TouchEventQueue19TouchTimeoutHandler17ConfirmTouchEventENS_18InputEventAckStateE fun:_ZN7content15TouchEventQueue15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE fun:_ZN7content19TouchEventQueueTest17SendTouchEventAckENS_18InputEventAckStateE fun:_ZN7content42TouchEventQueueTest_TouchTimeoutBasic_Test8TestBodyEv etc > Implement async touchmove dispatch during scroll > > This implements a touch dispatch model in which touchmove sending is throttled > while a scroll sequence is active and being consumed. Such touchmove's are > marked with |cancelable = false|, indicating to any potential consumers that the > event cannot be prevented from triggering a platform gesture. Throttling limits > the touchmove sending rate during scrolling to 1 event per 200ms. > > BUG=346693 > > Review URL: https://codereview.chromium.org/245833002 TBR=jdduke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -562 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/about_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/input_router_impl.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/input_router_impl_unittest.cc View 14 chunks +51 lines, -47 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/touch_event_queue.h View 5 chunks +19 lines, -41 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/touch_event_queue.cc View 16 chunks +83 lines, -203 lines 0 comments Download
M trunk/src/content/browser/renderer_host/input/touch_event_queue_unittest.cc View 7 chunks +21 lines, -234 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_unittest.cc View 28 chunks +70 lines, -0 lines 0 comments Download
M trunk/src/content/common/input/web_input_event_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/common/input/web_input_event_traits.cc View 1 chunk +14 lines, -17 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/input/input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 7 months ago (2014-04-28 15:43:01 UTC) #1
Nico
Committed patchset #1 manually as r266579.
6 years, 7 months ago (2014-04-28 15:45:01 UTC) #2
jdduke (slow)
6 years, 7 months ago (2014-04-28 15:46:58 UTC) #3
Message was sent while issue was closed.
On 2014/04/28 15:45:01, Nico wrote:
> Committed patchset #1 manually as r266579.

Have a fix landing but OK... https://codereview.chromium.org/253813003/

Powered by Google App Engine
This is Rietveld 408576698