Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2520003003: [Predator] Abort publishing result when the analysis failed. (Closed)

Created:
4 years, 1 month ago by Sharu Jiang
Modified:
4 years, 1 month ago
Reviewers:
wrengr, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Martin Barbella
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Predator] Abort publishing result when the analysis failed. TBR=stgao@chromium.org BUG=667550 Committed: https://chromium.googlesource.com/infra/infra/+/9a7e6f1259601c87e05fa05fd00f8a28cf665f19

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M appengine/findit/crash/crash_pipeline.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sharu Jiang
PTAL :)
4 years, 1 month ago (2016-11-22 00:45:50 UTC) #2
wrengr
lgtm, with nit/comment https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/crash_pipeline.py File appengine/findit/crash/crash_pipeline.py (right): https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/crash_pipeline.py#newcode184 appengine/findit/crash/crash_pipeline.py:184: repr(self._crash_identifiers), self.client_id) Since the crash identifiers ...
4 years, 1 month ago (2016-11-22 18:37:50 UTC) #3
Sharu Jiang
https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/crash_pipeline.py File appengine/findit/crash/crash_pipeline.py (right): https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/crash_pipeline.py#newcode184 appengine/findit/crash/crash_pipeline.py:184: repr(self._crash_identifiers), self.client_id) On 2016/11/22 18:37:49, wrengr wrote: > Since ...
4 years, 1 month ago (2016-11-22 18:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520003003/20001
4 years, 1 month ago (2016-11-22 18:59:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520003003/20001
4 years, 1 month ago (2016-11-22 19:00:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/9a7e6f1259601c87e05fa05fd00f8a28cf665f19
4 years, 1 month ago (2016-11-22 19:15:39 UTC) #14
stgao
4 years, 1 month ago (2016-11-22 21:24:03 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698