[Predator] Abort publishing result when the analysis failed.

[Predator] Abort publishing result when the analysis failed.

TBR=stgao@chromium.org
BUG=667550
Committed: https://chromium.googlesource.com/infra/infra/+/9a7e6f1259601c87e05fa05fd00f8a28cf665f19

[Sharu Jiang, 2016-11-22 00:45:49]

katesonia@chromium.org changed reviewers:
+ stgao@chromium.org, wrengr@chromium.org

[Sharu Jiang, 2016-11-22 00:45:50]

PTAL :)

[wrengr, 2016-11-22 18:37:50]

lgtm, with nit/comment

https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/cras...
File appengine/findit/crash/crash_pipeline.py (right):

https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/cras...
appengine/findit/crash/crash_pipeline.py:184: repr(self._crash_identifiers),
self.client_id)
Since the crash identifiers might be long, I'd rephrase things to put it at the
end. Maybe something like "Can't publish result to %s because analysis failed:
%s" ?

[Sharu Jiang, 2016-11-22 18:58:56]

https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/cras...
File appengine/findit/crash/crash_pipeline.py (right):

https://codereview.chromium.org/2520003003/diff/1/appengine/findit/crash/cras...
appengine/findit/crash/crash_pipeline.py:184: repr(self._crash_identifiers),
self.client_id)
On 2016/11/22 18:37:49, wrengr wrote:
> Since the crash identifiers might be long, I'd rephrase things to put it at
the
> end. Maybe something like "Can't publish result to %s because analysis failed:
> %s" ?

Done.

[Sharu Jiang, 2016-11-22 18:59:32]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2016-11-22 18:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from wrengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2520003003/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-11-22 18:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sharu Jiang, 2016-11-22 18:59:41]

The CQ bit was unchecked by katesonia@chromium.org

[Sharu Jiang, 2016-11-22 19:00:15]

Description was changed from

==========
[Predator] Abort publishing result when the analysis failed.

BUG=667550
==========

to

==========
[Predator] Abort publishing result when the analysis failed.

TBR=stgao@chromium.org
BUG=667550
==========

[Sharu Jiang, 2016-11-22 19:00:21]

The CQ bit was checked by katesonia@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:00:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:15:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479841221197900,
"parent_rev": "9709e25f8320d6e5ecdc8e183a8dd39e4b474e0e", "commit_rev":
"9a7e6f1259601c87e05fa05fd00f8a28cf665f19"}

[commit-bot: I haz the power, 2016-11-22 19:15:38]

Description was changed from

==========
[Predator] Abort publishing result when the analysis failed.

TBR=stgao@chromium.org
BUG=667550
==========

to

==========
[Predator] Abort publishing result when the analysis failed.

TBR=stgao@chromium.org
BUG=667550

Committed:
https://chromium.googlesource.com/infra/infra/+/9a7e6f1259601c87e05fa05fd00f8...
==========

[commit-bot: I haz the power, 2016-11-22 19:15:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/9a7e6f1259601c87e05fa05fd00f8...

[stgao, 2016-11-22 21:24:03]

lgtm