Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2190)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2520003003: [Predator] Abort publishing result when the analysis failed. (Closed)
Patch Set: Fix nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 52ef7a4d10d9942ba325519923862938ac69ac76..ae34261631005d0cc45a5874aea7f59ca55a735e 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -179,6 +179,11 @@ class PublishResultPipeline(CrashBasePipeline):
(except for ``self``, naturally).
"""
analysis = self._findit.GetAnalysis(self._crash_identifiers)
+ if analysis.failed:
+ logging.info('Can\'t publish result to %s because analysis failed:\n%s',
+ self.client_id, repr(self._crash_identifiers))
+ return
+
result = analysis.ToPublishableResult(self._crash_identifiers)
messages_data = [json.dumps(result, sort_keys=True)]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698