[Predator] Abort publishing result when the analysis failed.

appengine/findit/crash/crash_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import json
 import logging
 
 from common import appengine_util
 from common import pubsub_util
@@ skipping 161 matching lines @@
   def run(self, *_args, **_kwargs): # pragma: no cover
     """Publish the results of our analysis back into the ndb.Model.
 
     N.B., due to the structure of AppEngine pipelines, this method must
     accept the same arguments as are passed to ``__init__``; however,
     because they were already passed to ``__init__`` there's no use in
     recieving them here. Thus, we discard all the arguments to this method
     (except for ``self``, naturally).
     """
     analysis = self._findit.GetAnalysis(self._crash_identifiers)
+    if analysis.failed:
+      logging.info('Analysis of %s failed, abort publishing result to %s',
+                   repr(self._crash_identifiers), self.client_id)

[wrengr, 2016/11/22 18:37:49]

Since the crash identifiers might be long, I'd rephrase things to put it at the
end. Maybe something like "Can't publish result to %s because analysis failed:
%s" ?

[Sharu Jiang, 2016/11/22 18:58:56]

Done.

+      return
+
     result = analysis.ToPublishableResult(self._crash_identifiers)
     messages_data = [json.dumps(result, sort_keys=True)]
 
     # TODO(http://crbug.com/659354): remove Findit's dependency on CrashConfig.
     client_config = self._findit.config
     # TODO(katesonia): Clean string uses in config.
     topic = client_config['analysis_result_pubsub_topic']
     pubsub_util.PublishMessagesToTopic(messages_data, topic)
     logging.info('Published %s analysis result for %s', self.client_id,
                  repr(self._crash_identifiers))
@@ skipping 23 matching lines @@
     N.B., due to the structure of AppEngine pipelines, this method must
     accept the same arguments as are passed to ``__init__``; however,
     because they were already passed to ``__init__`` there's no use in
     recieving them here. Thus, we discard all the arguments to this method
     (except for ``self``, naturally).
     """
     run_analysis = yield CrashAnalysisPipeline(
         self._client_id, self._crash_identifiers)
     with pipeline.After(run_analysis):
       yield PublishResultPipeline(self._client_id, self._crash_identifiers)