Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2519853005: MD Settings: Enable to search "Add languages" list. (Closed)

Created:
4 years ago by SangGyeong.Jo
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Enable to search "Add languages" list. BUG=661342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Fix to follow JavaScript Style Guide #

Total comments: 5

Patch Set 3 : Fix scrollbar position and filter case-insensitive #

Patch Set 4 : Resolve minor conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.html View 1 2 3 3 chunks +18 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.js View 1 2 3 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
SangGyeong.Jo
Dan Beam@ PTAL
4 years ago (2016-11-23 02:05:07 UTC) #4
SangGyeong.Jo
On 2016/11/23 02:05:07, SangGyeong.Jo wrote: > Dan Beam@ > PTAL @michaelpg PTAL
4 years ago (2016-11-24 05:00:13 UTC) #6
michaelpg
On 2016/11/24 05:00:13, SangGyeong.Jo wrote: > On 2016/11/23 02:05:07, SangGyeong.Jo wrote: > > Dan Beam@ ...
4 years ago (2016-11-29 01:59:38 UTC) #7
SangGyeong.Jo
On 2016/11/29 01:59:38, michaelpg wrote: > On 2016/11/24 05:00:13, SangGyeong.Jo wrote: > > On 2016/11/23 ...
4 years ago (2016-11-30 02:07:48 UTC) #8
michaelpg
I think we should probably use <settings-subpage-search>, with some tweaks for a dialog. I'll get ...
4 years ago (2016-12-01 20:40:13 UTC) #9
michaelpg
dpapad, could you take over for me with respect to making a search box inside ...
4 years ago (2016-12-02 03:56:41 UTC) #11
SangGyeong.Jo
I fixed the position of scrollbar and it appears at original place. But I think ...
4 years ago (2016-12-05 18:29:44 UTC) #12
dpapad
@SangGyeong: Are you still interested in landing this CL (sorry for the long delay in ...
3 years, 9 months ago (2017-02-28 01:23:22 UTC) #13
SangGyeong.Jo
On 2017/02/28 01:23:22, dpapad wrote: > @SangGyeong: Are you still interested in landing this CL ...
3 years, 9 months ago (2017-02-28 02:41:07 UTC) #14
SangGyeong.Jo
@dpapad: I rebased by CL and resolved minor conflicts. Please take a look. Thank you.
3 years, 9 months ago (2017-03-19 17:41:49 UTC) #15
dpapad
On 2017/03/19 at 17:41:49, SangGyeong.Jo wrote: > @dpapad: I rebased by CL and resolved minor ...
3 years, 9 months ago (2017-03-20 18:01:31 UTC) #16
michaelpg
3 years, 7 months ago (2017-05-09 20:56:23 UTC) #18
Closing CL as issue is resolved.

Powered by Google App Engine
This is Rietveld 408576698