Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.html

Issue 2519853005: MD Settings: Enable to search "Add languages" list. (Closed)
Patch Set: Fix to follow JavaScript Style Guide Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">
michaelpg 2016/12/01 20:40:13 alphabetize (move below paper-checkbox)
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
6 <link rel="import" href="/languages_page/languages.html"> 8 <link rel="import" href="/languages_page/languages.html">
7 <link rel="import" href="/settings_shared_css.html"> 9 <link rel="import" href="/settings_shared_css.html">
8 10
9 <dom-module id="settings-add-languages-dialog"> 11 <dom-module id="settings-add-languages-dialog">
10 <template> 12 <template>
11 <style include="settings-shared"> 13 <style include="settings-shared">
12 dialog { 14 dialog {
13 display: flex; 15 display: flex;
14 flex-direction: column; 16 flex-direction: column;
15 } 17 }
16 18
17 .body { 19 .body {
18 display: flex; 20 display: flex;
19 flex-direction: column; 21 flex-direction: column;
20 max-height: 250px; 22 max-height: 250px;
21 overflow: auto; 23 overflow: auto;
22 } 24 }
23 25
24 .ripple-padding { 26 .ripple-padding {
25 /* Create a little extra space for checkbox ink ripple to flow into. */ 27 /* Create a little extra space for checkbox ink ripple to flow into. */
26 padding-left: 20px; 28 padding-left: 20px;
27 } 29 }
28 </style> 30 </style>
29 <dialog is="cr-dialog" id="dialog"> 31 <dialog is="cr-dialog" id="dialog">
30 <div class="title">$i18n{addLanguagesDialogTitle}</div> 32 <div class="title">$i18n{addLanguagesDialogTitle}</div>
31 <div class="body"> 33 <div class="body">
32 <!-- TODO(michaelpg): Dynamic language search/filtering. --> 34 <paper-input-container>
michaelpg 2016/12/02 03:56:41 +dpapad to figure out the best way to add a filter
33 <iron-list class="ripple-padding" scroll-target="[[$$('.body')]]" 35 <input is="iron-input" bind-value="{{filterValue_}}">
36 </paper-input-container>
37 <iron-list class="ripple-padding" scroll-target="[[$$('.ripple-padding') ]]"
michaelpg 2016/12/01 20:40:13 keep to 80-column lines (e.g., break before scroll
34 items="[[getAvailableLanguages_( 38 items="[[getAvailableLanguages_(
35 languages.supported, languages.enabled.*)]]"> 39 languages.supported, languages.enabled.*, filterValue_)]]">
36 <template> 40 <template>
37 <paper-checkbox class="list-item" checked="[[willAdd_(item.code)]]" 41 <paper-checkbox class="list-item" checked="[[willAdd_(item.code)]]"
38 title$="[[item.nativeDisplayName]]" 42 title$="[[item.nativeDisplayName]]"
39 on-change="onLanguageCheckboxChange_"> 43 on-change="onLanguageCheckboxChange_">
40 [[item.displayName]] 44 [[item.displayName]]
41 </paper-checkbox> 45 </paper-checkbox>
42 </template> 46 </template>
43 </iron-list> 47 </iron-list>
44 </div> 48 </div>
45 <div class="button-container"> 49 <div class="button-container">
46 <div class="action-buttons"> 50 <div class="action-buttons">
47 <paper-button class="cancel-button" on-tap="onCancelButtonTap_"> 51 <paper-button class="cancel-button" on-tap="onCancelButtonTap_">
48 $i18n{cancel} 52 $i18n{cancel}
49 </paper-button> 53 </paper-button>
50 <paper-button class="action-button" on-tap="onActionButtonTap_" 54 <paper-button class="action-button" on-tap="onActionButtonTap_"
51 disabled="[[disableActionButton_]]"> 55 disabled="[[disableActionButton_]]">
52 $i18n{add} 56 $i18n{add}
53 </paper-button> 57 </paper-button>
54 </div> 58 </div>
55 </div> 59 </div>
56 </dialog> 60 </dialog>
57 </template> 61 </template>
58 <script src="add_languages_dialog.js"></script> 62 <script src="add_languages_dialog.js"></script>
59 </dom-module> 63 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698