Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.js

Issue 2519853005: MD Settings: Enable to search "Add languages" list. (Closed)
Patch Set: Resolve minor conflicts Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/languages_page/add_languages_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.js
diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
index 8c687d7ea027f571ad410bdfa8a7aba418bd0a1d..1dffd25b80f71f6ce52555f9b09fbaf877b40883 100644
--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
@@ -30,6 +30,12 @@ Polymer({
type: Boolean,
value: true,
},
+
+ /** @private */
+ filterValue_: {
+ type: String,
+ value: '',
+ },
},
attached: function() {
@@ -55,18 +61,31 @@ Polymer({
},
/**
- * Returns the supported languages that are not yet enabled, based on
+ * Returns the supported languages that are not yet enabled
+ * and matching with filter keyword, based on
* the LanguageHelper's enabled languages list.
* @param {!Array<!chrome.languageSettingsPrivate.Language>}
* supportedLanguages
* @param {!Object} enabledLanguagesChange Polymer change record for
* |enabledLanguages|.
+ * @param {string} filterValue Keyword to filter languages in
+ * supported languages.
* @return {!Array<!chrome.languageSettingsPrivate.Language>}
* @private
*/
- getAvailableLanguages_: function(supportedLanguages, enabledLanguagesChange) {
+ getAvailableLanguages_: function(supportedLanguages,
+ enabledLanguagesChange,
+ filterValue) {
return supportedLanguages.filter(function(language) {
- return !this.languageHelper.isLanguageEnabled(language.code);
+ var isAvailableLanguage =
+ !this.languageHelper.isLanguageEnabled(language.code);
+ if (!filterValue) {
+ return isAvailableLanguage;
+ } else {
+ return isAvailableLanguage &&
+ language.displayName
+ .toLowerCase().includes(filterValue.toLowerCase());
+ }
}.bind(this));
},
« no previous file with comments | « chrome/browser/resources/settings/languages_page/add_languages_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698