Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2519803003: win: Delete the pdb before linking an exe for official (Closed)

Created:
4 years, 1 month ago by scottmg
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Delete the pdb before linking an exe for official Note that `cmd /c del $pdbname && ...` doesn't work because $pdbname has forward slashes. R=sebmarchand@chromium.org BUG=665773 Committed: https://crrev.com/06d7bfeeaeb3e6318fa9df589a37a3346aa31b34 Cr-Commit-Position: refs/heads/master@{#433746}

Patch Set 1 #

Patch Set 2 : forgot to grab latest snapshot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M build/toolchain/win/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M build/toolchain/win/tool_wrapper.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
scottmg
4 years, 1 month ago (2016-11-22 00:20:50 UTC) #2
Sébastien Marchand
On 2016/11/22 00:20:39, scottmg wrote: > Description was changed from > > ========== > win: ...
4 years, 1 month ago (2016-11-22 00:22:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519803003/1
4 years, 1 month ago (2016-11-22 00:33:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519803003/20001
4 years, 1 month ago (2016-11-22 00:36:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 02:17:15 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:21:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06d7bfeeaeb3e6318fa9df589a37a3346aa31b34
Cr-Commit-Position: refs/heads/master@{#433746}

Powered by Google App Engine
This is Rietveld 408576698