Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 2519803003: win: Delete the pdb before linking an exe for official (Closed)
Patch Set: forgot to grab latest snapshot Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/win/tool_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index ccc0a9435f6fd2ab5da717e0b13066cdab60cd21..10e617b05c8aa195452feb4c16351e97aaa669a1 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -264,6 +264,14 @@ template("msvc_toolchain") {
command = "$python_path $tool_wrapper_path link-wrapper $env False $link /nologo /OUT:$exename /PDB:$pdbname @$rspfile"
+ if (is_official_build) {
+ # On bots, the binary's PDB grow and eventually exceed 4G, causing the
+ # link to fail. As there's no utility to keeping the PDB around
+ # incrementally anyway in this config (because we're doing
+ # non-incremental LTCG builds), delete it before linking.
+ command = "cmd /c $python_path $tool_wrapper_path delete-file $pdbname && $command"
+ }
+
default_output_extension = ".exe"
default_output_dir = "{{root_out_dir}}"
description = "LINK {{output}}"
« no previous file with comments | « no previous file | build/toolchain/win/tool_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698