Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: build/toolchain/win/BUILD.gn

Issue 2519803003: win: Delete the pdb before linking an exe for official (Closed)
Patch Set: forgot to grab latest snapshot Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/win/tool_wrapper.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/clang/clang.gni") 5 import("//build/config/clang/clang.gni")
6 import("//build/config/compiler/compiler.gni") 6 import("//build/config/compiler/compiler.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/win/visual_studio_version.gni") 8 import("//build/config/win/visual_studio_version.gni")
9 import("//build/toolchain/goma.gni") 9 import("//build/toolchain/goma.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 } 257 }
258 258
259 tool("link") { 259 tool("link") {
260 exename = "{{output_dir}}/{{target_output_name}}{{output_extension}}" 260 exename = "{{output_dir}}/{{target_output_name}}{{output_extension}}"
261 pdbname = "$exename.pdb" 261 pdbname = "$exename.pdb"
262 rspfile = "$exename.rsp" 262 rspfile = "$exename.rsp"
263 pool = "//build/toolchain:link_pool($default_toolchain)" 263 pool = "//build/toolchain:link_pool($default_toolchain)"
264 264
265 command = "$python_path $tool_wrapper_path link-wrapper $env False $link / nologo /OUT:$exename /PDB:$pdbname @$rspfile" 265 command = "$python_path $tool_wrapper_path link-wrapper $env False $link / nologo /OUT:$exename /PDB:$pdbname @$rspfile"
266 266
267 if (is_official_build) {
268 # On bots, the binary's PDB grow and eventually exceed 4G, causing the
269 # link to fail. As there's no utility to keeping the PDB around
270 # incrementally anyway in this config (because we're doing
271 # non-incremental LTCG builds), delete it before linking.
272 command = "cmd /c $python_path $tool_wrapper_path delete-file $pdbname & & $command"
273 }
274
267 default_output_extension = ".exe" 275 default_output_extension = ".exe"
268 default_output_dir = "{{root_out_dir}}" 276 default_output_dir = "{{root_out_dir}}"
269 description = "LINK {{output}}" 277 description = "LINK {{output}}"
270 outputs = [ 278 outputs = [
271 exename, 279 exename,
272 ] 280 ]
273 if (symbol_level != 0) { 281 if (symbol_level != 0) {
274 outputs += [ pdbname ] 282 outputs += [ pdbname ]
275 } 283 }
276 runtime_outputs = outputs 284 runtime_outputs = outputs
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 msvc_toolchain("winrt_x64") { 429 msvc_toolchain("winrt_x64") {
422 environment = "environment.winrt_x64" 430 environment = "environment.winrt_x64"
423 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\"" 431 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
424 432
425 toolchain_args = { 433 toolchain_args = {
426 is_clang = false 434 is_clang = false
427 current_cpu = "x64" 435 current_cpu = "x64"
428 } 436 }
429 } 437 }
430 } 438 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/win/tool_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698