Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2519393002: Force adding sheets and recalc for html import re-ordering. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force adding sheets and recalc for html import re-ordering. When we remove an import link and re-insert it into the document, the import Document and CSSStyleSheet pointers are persisted. That means the comparison of active stylesheets is not able to figure out that the order of the stylesheets have changed after insertion. We fall back to re-add all sheets to the scoped resolver and recalculate style for the whole document if we remove an import in case it is re- inserted into the document. The assumption is that removing html imports is very rare. For re-ordering of link rel=stylesheet the CSSStyleSheet object is cleared on removal and recreated on insertion. Since the active stylesheet list keeps references to CSSStyleSheet, CSSStyleSheet pointers will not be re-used. R=meade@chromium.org TEST=fast/html/imports/import-readd-* BUG=567021 Committed: https://crrev.com/2790e7fc5577e8f434410719e00f3b55a155c981 Cr-Commit-Position: refs/heads/master@{#434374}

Patch Set 1 #

Patch Set 2 : Missing reset in resetAuthorStyle() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +29 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (15 generated)
rune
ptal
4 years, 1 month ago (2016-11-22 16:34:06 UTC) #5
rune
ptal
4 years, 1 month ago (2016-11-22 16:34:06 UTC) #6
meade_UTC10
lgtm
4 years ago (2016-11-24 06:30:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519393002/20001
4 years ago (2016-11-24 07:47:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 09:48:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519393002/20001
4 years ago (2016-11-24 10:00:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 12:02:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519393002/20001
4 years ago (2016-11-24 17:31:14 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 18:58:49 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-24 19:02:27 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2790e7fc5577e8f434410719e00f3b55a155c981
Cr-Commit-Position: refs/heads/master@{#434374}

Powered by Google App Engine
This is Rietveld 408576698