Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2521063005: Move MediaQueryEvaluator from StyleResolver to StyleEngine. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaQueryEvaluator from StyleResolver to StyleEngine. The plan is to move active stylesheet update and viewport/device- dependent media query results from StyleResolver to StyleEngine which means it makes sense to move the MediaQueryEvaluator there as well. That means that the StyleResolver will temporarily ask the StyleEngine for the evaluator when needed. See https://codereview.chromium.org/1913833002/ for planned changes. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/f01a414b7cafd436503dac1407fa7422533ffa47 Cr-Commit-Position: refs/heads/master@{#434144}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 5 chunks +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 2 5 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 2 5 chunks +18 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rune
ptal
4 years ago (2016-11-22 18:00:14 UTC) #3
meade_UTC10
lgtm
4 years ago (2016-11-22 23:51:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521063005/40001
4 years ago (2016-11-23 09:16:30 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-23 11:09:26 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-23 11:11:29 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f01a414b7cafd436503dac1407fa7422533ffa47
Cr-Commit-Position: refs/heads/master@{#434144}

Powered by Google App Engine
This is Rietveld 408576698