[DevTools] Remove HandlerRegistry.

[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
Committed: https://crrev.com/5d75addb33b2790805d66ef51ff2c615e17b549b
Cr-Commit-Position: refs/heads/master@{#434035}

[dgozman, 2016-11-21 19:19:19]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-11-21 19:19:19]

Could you please take a look?

[pfeldman, 2016-11-21 19:54:58]

Description was changed from

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
==========

to

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
==========

[pfeldman, 2016-11-21 19:54:58]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-11-21 20:13:09]

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:462:
Components.Linkifier._linkHandlers =
Components.Linkifier._linkHandlers.filter(entry => entry.title !== title);
if we remove by title, this could as well be a map.

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:681:
Components.Linkifier.LinkHandlerSettingUI = class {
Does it really belong to Linkifier?

[lushnikov, 2016-11-21 20:51:09]

lgtm

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js
(left):

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js:96:
if (!(target instanceof Workspace.UISourceCode || target instanceof SDK.Resource
||
FYI: you no longer do this check, but it seems to be fine

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:430: if
(info.revealable) {
this changes the order: revealable now prevails over extensions

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:477: var
lineNumber = info.lineNumber || 0;
let's inline this to the use-site
uiLocation ? uiLocation.lineNumber : info.lineNumber || 0;

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:495: if
(contentProvider) {
let's move this to the end.

[dgozman, 2016-11-21 23:34:50]

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:430: if
(info.revealable) {
On 2016/11/21 20:51:09, lushnikov wrote:
> this changes the order: revealable now prevails over extensions

Fixed.

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:462:
Components.Linkifier._linkHandlers =
Components.Linkifier._linkHandlers.filter(entry => entry.title !== title);
On 2016/11/21 20:13:09, caseq wrote:
> if we remove by title, this could as well be a map.

Done.

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:477: var
lineNumber = info.lineNumber || 0;
On 2016/11/21 20:51:09, lushnikov wrote:
> let's inline this to the use-site
> uiLocation ? uiLocation.lineNumber : info.lineNumber || 0;

Done.

https://codereview.chromium.org/2516253002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:495: if
(contentProvider) {
On 2016/11/21 20:51:09, lushnikov wrote:
> let's move this to the end.

Done.

[dgozman, 2016-11-22 19:11:16]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-22 19:11:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2516253002/#ps20001
(title: "rebase, fixed comments")

[commit-bot: I haz the power, 2016-11-22 19:11:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:48:01]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dgozman, 2016-11-22 21:39:28]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:40:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:07:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479850768663990,
"parent_rev": "457a66b7b13015ccf8c2e74068d0ee7589e944aa", "commit_rev":
"61de69e9af98ecae27e451a9813dcd97b3676ca5"}

[commit-bot: I haz the power, 2016-11-23 00:07:50]

Description was changed from

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
==========

to

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
==========

[commit-bot: I haz the power, 2016-11-23 00:07:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 00:11:24]

Description was changed from

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661
==========

to

==========
[DevTools] Remove HandlerRegistry.

All meaningful functionality went to Linkifier.

BUG=665661

Committed: https://crrev.com/5d75addb33b2790805d66ef51ff2c615e17b549b
Cr-Commit-Position: refs/heads/master@{#434035}
==========

[commit-bot: I haz the power, 2016-11-23 00:11:25]

Patchset 2 (id:??) landed as
https://crrev.com/5d75addb33b2790805d66ef51ff2c615e17b549b
Cr-Commit-Position: refs/heads/master@{#434035}