Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2519213002: [DevTools] Remove preventFollow and special checks for links throughout frontend. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
index 2a4e99bb9116bb24966138b134f84756644245d2..53ae0294454924ef4e0911bb594c6e398e1ac9ed 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
@@ -342,9 +342,10 @@ Components.Linkifier = class {
* @param {string=} className
* @param {number=} lineNumber
* @param {number=} columnNumber
+ * @param {boolean=} preventClick
* @return {!Element}
*/
- static linkifyURL(url, text, className, lineNumber, columnNumber) {
+ static linkifyURL(url, text, className, lineNumber, columnNumber, preventClick) {
if (!url || url.trim().toLowerCase().startsWith('javascript:')) {
var element = createElementWithClass('span', className);
element.textContent = text || url || Common.UIString('(unknown)');
@@ -355,7 +356,7 @@ Components.Linkifier = class {
if (typeof lineNumber === 'number' && !text)
linkText += ':' + (lineNumber + 1);
var title = linkText !== url ? url : '';
- var link = Components.Linkifier._createLink(linkText.trimMiddle(150), className || '', title, url);
+ var link = Components.Linkifier._createLink(linkText.trimMiddle(150), className || '', title, url, preventClick);
var info = Components.Linkifier._linkInfo(link);
if (typeof lineNumber === 'number')
info.lineNumber = lineNumber;
@@ -382,9 +383,10 @@ Components.Linkifier = class {
* @param {string} className
* @param {string=} title
* @param {string=} href
+ * @param {boolean=} preventClick
* @returns{!Element}
*/
- static _createLink(text, className, title, href) {
+ static _createLink(text, className, title, href, preventClick) {
var link = createElementWithClass('a', className);
link.classList.add('webkit-html-resource-link');
if (title)
@@ -403,7 +405,10 @@ Components.Linkifier = class {
revealable: null,
fallback: null
};
- link.addEventListener('click', Components.Linkifier._handleClick, false);
+ if (preventClick)
+ link.addEventListener('click', event => event.consume(true), false);
+ else
+ link.addEventListener('click', Components.Linkifier._handleClick, false);
return link;
}

Powered by Google App Engine
This is Rietveld 408576698