Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2518903002: Make SearchMatch an interface, exclude 'context', move implementation. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make SearchMatch an interface, exclude 'context', move implementation. Also, mostly drop 'fileStamp' in SourceFileEdit. Only `-1` is kept when the file is a new one, in other cases it' `0`. As I can see, IDEA cares only about `-1`. We don't know modification stamps with the new analysis driver. But we know content hashes. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/73fccff8ea6995a903866fc83f4af94feb9ded26

Patch Set 1 #

Total comments: 1

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-20 23:53:35 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-21 13:29:35 UTC) #2
Brian Wilkerson
> As I can see, IDEA cares only about `-1`. Do we know what the ...
4 years, 1 month ago (2016-11-21 15:00:56 UTC) #3
scheglov
4 years, 1 month ago (2016-11-21 18:05:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73fccff8ea6995a903866fc83f4af94feb9ded26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698