pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart - Issue 2518903002: Make SearchMatch an interface, exclude 'context', move implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

Issue 2518903002: Make SearchMatch an interface, exclude 'context', move implementation. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/protocol_server.dart ('K') | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart b/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

index 17fdb68f205fa9fa5dbf24122fdff258b167259b..7e18c6b9cfbabb187ecdf701a522f122a59ca268 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

@@ -12,7 +12,6 @@ import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/dart/element/element.dart';

-import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;

import 'package:analyzer/src/generated/source.dart';

/**

@@ -68,8 +67,6 @@ class SourceReference {

SourceReference(this._match);

- AnalysisContext get context => _match.context;

Element get element => _match.element;

/**

@@ -106,7 +103,7 @@ class SourceReference {

void addEdit(SourceChange change, String newText, {String id}) {

SourceEdit edit = createEdit(newText, id: id);

- doSourceChange_addSourceEdit(change, context, unitSource, edit);

+ doSourceChange_addSourceEdit(change, unitSource, edit);

}

/**