pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart - Issue 2518903002: Make SearchMatch an interface, exclude 'context', move implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 2518903002: Make SearchMatch an interface, exclude 'context', move implementation. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/protocol_server.dart ('K') | « pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart ('k') | pkg/analysis_server/lib/src/services/search/search_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

index 80fd4b1d09a3cec82927651aee2c0036facb4a98..cb9d88da82bc126af48ebad2d772e8c0a8fd0008 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

@@ -16,6 +16,7 @@ import 'package:analysis_server/src/services/refactoring/refactoring_internal.da

import 'package:analysis_server/src/services/refactoring/rename.dart';

import 'package:analysis_server/src/services/search/hierarchy.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

+import 'package:analysis_server/src/services/search/search_engine_internal.dart';

import 'package:analyzer/dart/ast/ast.dart';

import 'package:analyzer/dart/element/element.dart';

import 'package:analyzer/src/generated/java_core.dart';

@@ -96,7 +97,7 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {

} else {

sourceRange = rangeStartLength(element.nameEnd, 0);

}

- return new SourceReference(new SearchMatch(

+ return new SourceReference(new SearchMatchImpl(

element.context,

element.library.source.uri.toString(),

element.source.uri.toString(),