Move Partition Allocator into Chromium base.

base/compiler_specific.h

Index: base/compiler_specific.h
diff --git a/base/compiler_specific.h b/base/compiler_specific.h
index 0f4c058b3be43963d76c23b0b3b8ec89fc8b3767..278ef924f91ee36a70bf4042ecfd3aebd930ef72 100644
--- a/base/compiler_specific.h
+++ b/base/compiler_specific.h
@@ -230,4 +230,18 @@
 #define HAS_FEATURE(FEATURE) 0
 #endif
 
+#if defined(COMPILER_GCC)

[gab, 2016/12/05 18:51:48]

The last comment below makes this not compiler specific.

+#define PRETTY_FUNCTION __PRETTY_FUNCTION__
+#elif defined(COMPILER_MSVC)
+#define PRETTY_FUNCTION __FUNCSIG__
+#else
+#define PRETTY_FUNCTION __func__
+#endif
+
+// Returns a string that contains the type name of |T| as a substring.
+template <typename T>
+inline const char* GetStringWithTypeName() {

[gab, 2016/12/05 18:51:48]

Given this is only used in base/allocator it should live in it (ref.
base/OWNERS).

[palmer, 2016/12/06 00:58:25]

Turns out I can leave it in WTF (since I moved
wtf/allocator/PartitionAllocator.h back into WTF). So we can get rid of this
entirely.

+  return PRETTY_FUNCTION;

[gab, 2016/12/05 18:51:48]

I think typeid(T).name() would be cleaner here?

http://en.cppreference.com/w/cpp/language/typeid

Though type_info::name is implementation defined
(http://en.cppreference.com/w/cpp/types/type_info), so it might be mangled,
depends how hard this needs to contain "T" perfectly as a substring?

[palmer, 2016/12/06 00:58:25]

It would be, but the compiler says: "error: cannot use typeid with -fno-rtti".
Alas!

[gab, 2016/12/06 15:43:21]

Interesting, I couldn't find where this flag is set in GN but I found another
callsite that would like it not to be:
https://cs.chromium.org/chromium/src/gin/function_template.h?rcl=0&l=142

Since your method is only intended to be used in Debug builds maybe it'd make
sense to enable RTTI in Debug builds?

+}
+
 #endif  // BASE_COMPILER_SPECIFIC_H_