Move Partition Allocator into Chromium base.

base/BUILD.gn

Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index bbdf07372b1f6b7cec573965e752c60f019376d7..5b946345d1823a7a6c8973cf850747fc496d1c56 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1220,6 +1220,17 @@ component("base") {
       "rand_util_nacl.cc",
       "synchronization/read_write_lock_nacl.cc",
     ]
+
+    # Add stuff that doesn't work in NaCl.
+    sources += [

[gab, 2016/12/05 18:51:48]

Add these to all sources and instead add the exception to the source-= group of
if(is_nacl) on 1147.

[palmer, 2016/12/06 00:58:25]

In an earlier code review, thakis said the general preference to + things rather
than to -= them. (Despite the fact that there is a lot of legacy -= going on.)

I'm agnostic but confused. :)

[gab, 2016/12/06 15:43:21]

Interesting, I'll discuss with him offline. I thought the prefered approach in
the new GN world was to avoid having so many conditions and as such including
files in the default entry and merely removing them with a comment of why where
they don't apply.

I find if(foo) { sources -= [...] } reads better than if (foo) { ... } else {
sources += [...] }

But code search speaks in favor of sources += (295) vs sources -= (92)
https://cs.chromium.org/search/?q=%22sources+%2B%3D%22+file:BUILD.gn&sq=packa...

[gab, 2016/12/06 15:55:06]

Spoke with Nico, preference is now sources += in GN. He'll send a PSA to
chromium-dev introducing this at large later today.

+      # PartitionAlloc uses SpinLock, which doesn't work in NaCl (see below).
+      "allocator/partition_allocator/address_space_randomization.cc",
+      "allocator/partition_allocator/address_space_randomization.h",
+      "allocator/partition_allocator/page_allocator.cc",
+      "allocator/partition_allocator/page_allocator.h",
+      "allocator/partition_allocator/partition_alloc.cc",
+      "allocator/partition_allocator/partition_alloc.h",
+    ]
   }
 
   # SpinLock uses inline assembly that doesn't work on NaCl, and for which there
@@ -1785,6 +1796,7 @@ if (is_ios || is_mac) {
 
 test("base_unittests") {
   sources = [
+    "allocator/partition_allocator/partition_alloc_unittest.cc",
     "allocator/tcmalloc_unittest.cc",
     "android/application_status_listener_unittest.cc",
     "android/content_uri_utils_unittest.cc",