Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2518233004: MD Settings: Move settings-advanced-page into settings-basic-page (Closed)

Created:
4 years, 1 month ago by michaelpg
Modified:
4 years ago
Reviewers:
Dan Beam, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Move settings-advanced-page into settings-basic-page Merges settings-basic-page and settings-advanced-page by into one element. This simplifies a lot of behavior (we no longer have two MainPageBehavior instances trying to scroll #mainContainter at the same time) which fixes some bugs for free. Functionality in settings-main that was specific to the settings pages has been moved into settings-basic page, simplifying settings-main. Unfortunately, settings-main still shares an annoying amount with setting-basic-page, namely inSearchMode and advancedToggleExpanded. The main bug this fixes is issue 662004: tapping a Basic page section from an Advanced page sub-page (or vice versa) would fail to scroll to the new section. Minor bugs that this fixes: * after opening a subpage, tapping a section in the nav menu closed the subpage but only jumped to the new section after an awkward delay * after loading a subpage URL, tapping the back icon button caused the page to jump to the top, then back down * navigating from a Basic subpage to an Advanced subpage, or vice versa, would have hidden one of the main pages while transitioning Note: settings-basic-page should be renamed now that "basic" is meaningless, but unfortunately every conceivable alternative name is already taken, except for settings-settings-page which is horrible for reasons too numerous to mention. BUG=662004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5 Cr-Commit-Position: refs/heads/master@{#438738}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : remove some redundancy #

Total comments: 6

Patch Set 4 : rebase/fix line lengths #

Total comments: 14

Patch Set 5 : dpapad comments #

Patch Set 6 : rebase #

Patch Set 7 : git squash commit. #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -469 lines) Patch
D chrome/browser/resources/settings/advanced_page/advanced_page.html View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/resources/settings/advanced_page/advanced_page.js View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 2 3 4 5 6 1 chunk +219 lines, -61 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 1 2 3 4 5 6 4 chunks +140 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/basic_page/compiled_resources2.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_settings.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 3 4 5 6 2 chunks +3 lines, -58 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 2 3 4 5 8 chunks +12 lines, -106 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 7 2 chunks +1 line, -9 lines 0 comments Download
M chrome/test/data/webui/settings/advanced_page_browsertest.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/settings_main_test.js View 4 chunks +54 lines, -26 lines 0 comments Download
M chrome/test/data/webui/settings/settings_page_browsertest.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/settings_subpage_browsertest.js View 1 5 chunks +38 lines, -44 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
michaelpg
PTAL. dpapad, especially look at how settings-main and settings-basic-page interact for searching now. Outside of ...
4 years, 1 month ago (2016-11-23 00:50:04 UTC) #6
dpapad
https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/settings_main/settings_main.html File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/settings_main/settings_main.html#newcode39 chrome/browser/resources/settings/settings_main/settings_main.html:39: advanced-toggle-expanded="{{advancedToggleExpanded}}" I don't see any remaining usages of advancedToggleExpanded ...
4 years ago (2016-11-23 20:40:04 UTC) #7
michaelpg
https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/settings_main/settings_main.html File chrome/browser/resources/settings/settings_main/settings_main.html (right): https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/settings_main/settings_main.html#newcode39 chrome/browser/resources/settings/settings_main/settings_main.html:39: advanced-toggle-expanded="{{advancedToggleExpanded}}" On 2016/11/23 20:40:04, dpapad wrote: > I don't ...
4 years ago (2016-11-23 22:43:34 UTC) #8
dpapad
https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/basic_page/basic_page.html File chrome/browser/resources/settings/basic_page/basic_page.html (right): https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/basic_page/basic_page.html#newcode12 chrome/browser/resources/settings/basic_page/basic_page.html:12: <link rel="import" href="/reset_page/reset_profile_banner.html"> I am realizing that all those ...
4 years ago (2016-11-28 20:04:45 UTC) #9
michaelpg
https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/basic_page/basic_page.html File chrome/browser/resources/settings/basic_page/basic_page.html (right): https://codereview.chromium.org/2518233004/diff/40001/chrome/browser/resources/settings/basic_page/basic_page.html#newcode12 chrome/browser/resources/settings/basic_page/basic_page.html:12: <link rel="import" href="/reset_page/reset_profile_banner.html"> On 2016/11/28 20:04:44, dpapad wrote: > ...
4 years ago (2016-12-02 01:51:44 UTC) #10
dpapad
> I'm not sure I understand/agree. Before this merge, the HTML imports in advanced_page.html were ...
4 years ago (2016-12-02 19:45:54 UTC) #11
michaelpg
Thanks. dbeam, did you want to take a look or shall I submit? I won't ...
4 years ago (2016-12-08 03:31:59 UTC) #13
Dan Beam
On 2016/12/08 03:31:59, michaelpg wrote: > Thanks. dbeam, did you want to take a look ...
4 years ago (2016-12-08 03:45:37 UTC) #14
michaelpg
On 2016/12/08 03:45:37, Dan Beam wrote: > On 2016/12/08 03:31:59, michaelpg wrote: > > Thanks. ...
4 years ago (2016-12-08 04:13:44 UTC) #15
dpapad
@michaelpg: FYI Tommy's https://codereview.chromium.org/2552393002 touched main_page_behavior.js and inSearchMode_ boolean. Perhaps there will be conflicts with ...
4 years ago (2016-12-08 18:50:56 UTC) #16
Dan Beam
On 2016/12/08 04:13:44, michaelpg wrote: > On 2016/12/08 03:45:37, Dan Beam wrote: > > On ...
4 years ago (2016-12-09 18:55:26 UTC) #17
Dan Beam
On 2016/12/09 18:55:26, Dan Beam wrote: > On 2016/12/08 04:13:44, michaelpg wrote: > > On ...
4 years ago (2016-12-09 18:55:50 UTC) #18
michaelpg
On 2016/12/09 18:55:50, Dan Beam wrote: > On 2016/12/09 18:55:26, Dan Beam wrote: > > ...
4 years ago (2016-12-09 22:02:27 UTC) #19
michaelpg
Rebased version uploaded. still works locally.
4 years ago (2016-12-12 23:43:00 UTC) #20
Dan Beam
i didn't actually look at the code, but i'll defer to dpapad@ on the review ...
4 years ago (2016-12-14 07:56:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518233004/160001
4 years ago (2016-12-15 00:57:09 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315165) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 01:04:37 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518233004/160001
4 years ago (2016-12-15 03:43:42 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:160001)
4 years ago (2016-12-15 04:29:43 UTC) #35
commit-bot: I haz the power
4 years ago (2016-12-15 04:32:44 UTC) #37
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5
Cr-Commit-Position: refs/heads/master@{#438738}

Powered by Google App Engine
This is Rietveld 408576698