Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2518233004: MD Settings: Move settings-advanced-page into settings-basic-page (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/promise_resolver.html"> 3 <link rel="import" href="chrome://resources/html/promise_resolver.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="/about_page/about_page.html"> 6 <link rel="import" href="/about_page/about_page.html">
7 <link rel="import" href="/advanced_page/advanced_page.html">
8 <link rel="import" href="/basic_page/basic_page.html"> 7 <link rel="import" href="/basic_page/basic_page.html">
9 <link rel="import" href="/route.html"> 8 <link rel="import" href="/route.html">
10 <link rel="import" href="/settings_page/main_page_behavior.html">
11 <link rel="import" href="/settings_vars_css.html"> 9 <link rel="import" href="/settings_vars_css.html">
12 10
13 <dom-module id="settings-main"> 11 <dom-module id="settings-main">
14 <template> 12 <template>
15 <style> 13 <style>
16 #advancedToggle {
17 --paper-button: {
18 text-transform: none;
19 }
20 @apply(--settings-actionable);
21 align-items: center;
22 display: flex;
23 margin-bottom: 3px;
24 margin-top: 12px; /* Part of a 48px spacer (33px + 12px + 3px). */
25 min-height: 32px;
26 padding: 0 12px;
27 }
28
29 #overscroll { 14 #overscroll {
30 margin-top: 64px; 15 margin-top: 64px;
31 } 16 }
32 17
33 #toggleContainer {
34 align-items: center;
35 display: flex;
36 font: inherit;
37 justify-content: center;
38 margin-bottom: 0;
39 margin-top: 0;
40 }
41
42 #toggleSpacer {
43 padding-top: 33px; /* Part of a 48px spacer (33px + 12px + 3px). */
44 }
45
46 iron-icon {
47 -webkit-margin-start: 16px;
48 }
49
50 #noSearchResults { 18 #noSearchResults {
51 align-items: center; 19 align-items: center;
52 display: flex; 20 display: flex;
53 flex-direction: column; 21 flex-direction: column;
54 margin-top: 80px; 22 margin-top: 80px;
55 } 23 }
56 24
57 #noSearchResults div:first-child { 25 #noSearchResults div:first-child {
58 font-size: 120%; 26 font-size: 120%;
59 margin-bottom: 10px; 27 margin-bottom: 10px;
60 } 28 }
61 </style> 29 </style>
62 <content select="paper-icon-button"></content> 30 <content select="paper-icon-button"></content>
63 <div id="noSearchResults" hidden$="[[!showNoResultsFound_]]"> 31 <div id="noSearchResults" hidden$="[[!showNoResultsFound_]]">
64 <div>$i18n{searchNoResults}</div> 32 <div>$i18n{searchNoResults}</div>
65 <div>$i18nRaw{searchNoResultsHelp}</div> 33 <div>$i18nRaw{searchNoResultsHelp}</div>
66 </div> 34 </div>
67 <template is="dom-if" if="[[showBasicPage_( 35 <template is="dom-if" if="[[showPages_.settings]]">
68 showPages_.basic, inSearchMode_, hasExpandedSection_)]]">
69 <settings-basic-page prefs="{{prefs}}" 36 <settings-basic-page prefs="{{prefs}}"
70 page-visibility="[[pageVisibility]]" 37 page-visibility="[[pageVisibility]]"
71 show-android-apps="[[showAndroidApps]]" 38 show-android-apps="[[showAndroidApps]]"
72 on-subpage-expand="onSubpageExpand_" 39 on-subpage-expand="onSubpageExpand_"
73 in-search-mode="[[inSearchMode_]]"> 40 in-search-mode="[[inSearchMode_]]"
41 advanced-toggle-expanded="{{advancedToggleExpanded}}">
74 </settings-basic-page> 42 </settings-basic-page>
75 </template> 43 </template>
76 <template is="dom-if"
77 if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">
78 <template is="dom-if" if="[[showAdvancedToggle_(
79 showPages_.basic, hasExpandedSection_, inSearchMode_)]]">
80 <div id="toggleSpacer"></div>
81 <h2 id="toggleContainer">
82 <paper-button id="advancedToggle" active="{{advancedToggleExpanded}}"
83 aria-active-attribute="aria-expanded" toggles>
84 <span>$i18n{advancedPageTitle}</span>
85 <iron-icon icon="[[arrowState_(advancedToggleExpanded)]]">
86 </iron-icon>
87 </paper-button>
88 </h2>
89 </template>
90 <template is="dom-if" if="[[showAdvancedPage_(
91 showPages_.advanced, inSearchMode_, hasExpandedSection_)]]">
92 <settings-advanced-page prefs="{{prefs}}"
93 page-visibility="[[pageVisibility]]"
94 on-subpage-expand="onSubpageExpand_"
95 in-search-mode="[[inSearchMode_]]">
96 </settings-advanced-page>
97 </template>
98 </template>
99 <template is="dom-if" if="[[showPages_.about]]"> 44 <template is="dom-if" if="[[showPages_.about]]">
100 <settings-about-page in-search-mode="[[inSearchMode_]]"> 45 <settings-about-page in-search-mode="[[inSearchMode_]]">
101 </settings-about-page> 46 </settings-about-page>
102 </template> 47 </template>
103 <div id="overscroll" style="padding-bottom: [[overscroll_]]px"></div> 48 <div id="overscroll" style="padding-bottom: [[overscroll_]]px"></div>
104 </template> 49 </template>
105 <script src="settings_main.js"></script> 50 <script src="settings_main.js"></script>
106 <script src="/search_settings.js"></script> 51 <script src="/search_settings.js"></script>
107 </dom-module> 52 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698