Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.

BUG=pdfium:633
Committed: https://pdfium.googlesource.com/pdfium/+/9e4fca796e2711fcd311b1203b75fdd7f737c9b5

[npm, 2016-11-22 22:08:54]

Description was changed from

==========
Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.

BUG=pdfium:633
==========

to

==========
Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.

BUG=pdfium:633
==========

[npm, 2016-11-22 22:08:54]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, tsepez@chromium.org

[npm, 2016-11-22 22:09:04]

ptal

[npm, 2016-11-22 22:11:18]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 22:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 22:27:58]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-23 14:10:53]

https://codereview.chromium.org/2518063005/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_cache.cpp (right):

https://codereview.chromium.org/2518063005/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_cache.cpp:303: m_pCachedMask = m_pCurMask;
This needs a if (m_pCurMask) to be consistent with the previous?

[npm, 2016-11-23 15:31:01]

https://codereview.chromium.org/2518063005/diff/1/core/fpdfapi/render/fpdf_re...
File core/fpdfapi/render/fpdf_render_cache.cpp (right):

https://codereview.chromium.org/2518063005/diff/1/core/fpdfapi/render/fpdf_re...
core/fpdfapi/render/fpdf_render_cache.cpp:303: m_pCachedMask = m_pCurMask;
On 2016/11/23 14:10:53, dsinclair wrote:
> This needs a if (m_pCurMask) to be consistent with the previous?

Done.

[dsinclair, 2016-11-23 15:34:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-23 15:34:43]

lgtm

[commit-bot: I haz the power, 2016-11-23 15:34:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 15:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479915283502840,
"parent_rev": "e36430e530e48d4145f34a554f9891b1989b590d", "commit_rev":
"9e4fca796e2711fcd311b1203b75fdd7f737c9b5"}

[commit-bot: I haz the power, 2016-11-23 15:49:03]

Description was changed from

==========
Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.

BUG=pdfium:633
==========

to

==========
Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.

BUG=pdfium:633

Committed:
https://pdfium.googlesource.com/pdfium/+/9e4fca796e2711fcd311b1203b75fdd7f737...
==========

[commit-bot: I haz the power, 2016-11-23 15:49:04]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9e4fca796e2711fcd311b1203b75fdd7f737...