Avoid cloning in CPDF_ImageCacheEntry::ContinueGetCachedBitmap

core/fpdfapi/render/fpdf_render_cache.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/render/cpdf_pagerendercache.h"
 
 #include "core/fpdfapi/page/cpdf_page.h"
 #include "core/fpdfapi/page/pageint.h"
@@ skipping 274 matching lines @@
     return ret;
   }
   if (!ret) {
     delete m_pCurBitmap;
     m_pCurBitmap = nullptr;
     return 0;
   }
   ContinueGetCachedBitmap();
   return 0;
 }
+
 void CPDF_ImageCacheEntry::ContinueGetCachedBitmap() {
   m_MatteColor = ((CPDF_DIBSource*)m_pCurBitmap)->GetMatteColor();
   m_pCurMask = ((CPDF_DIBSource*)m_pCurBitmap)->DetachMask();
   CPDF_RenderContext* pContext = m_pRenderStatus->GetContext();
   CPDF_PageRenderCache* pPageRenderCache = pContext->GetPageCache();
   m_dwTimeCount = pPageRenderCache->GetTimeCount();
-  if (m_pCurBitmap->GetPitch() * m_pCurBitmap->GetHeight() <
-      FPDF_HUGE_IMAGE_SIZE) {
-    m_pCachedBitmap = m_pCurBitmap->Clone();
-    delete m_pCurBitmap;
-    m_pCurBitmap = nullptr;
-  } else {
-    m_pCachedBitmap = m_pCurBitmap;
-  }
-  if (m_pCurMask) {
-    m_pCachedMask = m_pCurMask->Clone();
-    delete m_pCurMask;
-    m_pCurMask = nullptr;
-  }
-  m_pCurBitmap = m_pCachedBitmap;
-  m_pCurMask = m_pCachedMask;
+  m_pCachedBitmap = m_pCurBitmap;
+  if (m_pCurMask)
+    m_pCachedMask = m_pCurMask;
+  else
+    m_pCurMask = m_pCachedMask;
   CalcSize();
 }
+
 int CPDF_ImageCacheEntry::Continue(IFX_Pause* pPause) {
   int ret = ((CPDF_DIBSource*)m_pCurBitmap)->ContinueLoadDIBSource(pPause);
   if (ret == 2) {
     return ret;
   }
   if (!ret) {
     delete m_pCurBitmap;
     m_pCurBitmap = nullptr;
     return 0;
   }
   ContinueGetCachedBitmap();
   return 0;
 }
 void CPDF_ImageCacheEntry::CalcSize() {
   m_dwCacheSize = FPDF_ImageCache_EstimateImageSize(m_pCachedBitmap) +
                   FPDF_ImageCache_EstimateImageSize(m_pCachedMask);
 }