Always delete media galleries FilePathWatchers on the FILE thread.

Always delete media galleries FilePathWatchers on the FILE thread.

This CL uses content::BrowserThread::DeleteOnFileThread to guarantee
that FilePathWatchers created by StartFilePathWatchOnMediaTaskRunner()
are always deleted on the thread from which they were created (i.e.
the FILE thread).

BUG=665511
Committed: https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5
Cr-Commit-Position: refs/heads/master@{#433649}

[fdoray, 2016-11-21 16:39:33]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 16:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 16:54:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2016-11-21 17:00:59]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2016-11-21 17:01:14]

fdoray@chromium.org changed reviewers:
+ tommycli@chromium.org

[fdoray, 2016-11-21 17:01:14]

PTAL

[commit-bot: I haz the power, 2016-11-21 17:01:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:25:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fdoray, 2016-11-21 19:00:22]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 19:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-21 19:25:48]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-11-21 19:25:49]

Still have red bots...

[commit-bot: I haz the power, 2016-11-21 19:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:28:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fdoray, 2016-11-21 19:49:35]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[Lei Zhang, 2016-11-21 19:49:37]

LGTM in general, but you need to sort out the build errors. Assuming that's more
of the same. There are a bunch of media_galleries bits that are Mac/Win specific
because the apps media_galleries imports from only exist on those platforms.

[commit-bot: I haz the power, 2016-11-21 19:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-11-21 19:52:08]

On 2016/11/21 19:49:37, Lei Zhang (Mostly OOO) wrote:
> LGTM in general, but you need to sort out the build errors. Assuming that's
more
> of the same. There are a bunch of media_galleries bits that are Mac/Win
specific
> because the apps media_galleries imports from only exist on those platforms.

Thanks. Latest patch set solves the build errors observed on the bots.

[commit-bot: I haz the power, 2016-11-21 20:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:47:26]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-11-21 20:58:49]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 21:05:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1479761929290850,
"parent_rev": "e759fdbfa2a676f125b5ffe7c55e04a9b068e3d0", "commit_rev":
"18dbdc5cd0a7d0ebf995116a317565a214c9a3c1"}

[commit-bot: I haz the power, 2016-11-21 21:05:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-21 21:13:29]

Description was changed from

==========
Always delete media galleries FilePathWatchers on the FILE thread.

This CL uses content::BrowserThread::DeleteOnFileThread to guarantee
that FilePathWatchers created by StartFilePathWatchOnMediaTaskRunner()
are always deleted on the thread from which they were created (i.e.
the FILE thread).

BUG=665511
==========

to

==========
Always delete media galleries FilePathWatchers on the FILE thread.

This CL uses content::BrowserThread::DeleteOnFileThread to guarantee
that FilePathWatchers created by StartFilePathWatchOnMediaTaskRunner()
are always deleted on the thread from which they were created (i.e.
the FILE thread).

BUG=665511

Committed: https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5
Cr-Commit-Position: refs/heads/master@{#433649}
==========

[commit-bot: I haz the power, 2016-11-21 21:13:31]

Patchset 5 (id:??) landed as
https://crrev.com/6f5a068ec88b1f533a4bbd040f5dd6352ff112b5
Cr-Commit-Position: refs/heads/master@{#433649}