Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3422)

Unified Diff: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

Issue 2518053002: Always delete media galleries FilePathWatchers on the FILE thread. (Closed)
Patch Set: fix build error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
diff --git a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
index 3ccf2e4a7483b5b3402305f2364233e821a02102..9404431dd34e900faba72639a06fb8bc4eb6bcf0 100644
--- a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
+++ b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
@@ -15,7 +15,6 @@
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/threading/thread_restrictions.h"
-#include "chrome/browser/media_galleries/fileapi/file_path_watcher_util.h"
#include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
#include "chrome/common/media_galleries/itunes_library.h"
#include "storage/browser/fileapi/native_file_util.h"
@@ -39,9 +38,7 @@ IAppsDataProvider::IAppsDataProvider(const base::FilePath& library_path)
weak_factory_.GetWeakPtr()));
}
-IAppsDataProvider::~IAppsDataProvider() {
- StopFilePathWatchOnMediaTaskRunner(std::move(library_watcher_));
-}
+IAppsDataProvider::~IAppsDataProvider() {}
bool IAppsDataProvider::valid() const {
return is_valid_;
@@ -68,7 +65,7 @@ const base::FilePath& IAppsDataProvider::library_path() const {
}
void IAppsDataProvider::OnLibraryWatchStarted(
- std::unique_ptr<base::FilePathWatcher> library_watcher) {
+ MediaFilePathWatcherUniquePtr library_watcher) {
MediaFileSystemBackend::AssertCurrentlyOnMediaSequence();
library_watcher_ = std::move(library_watcher);
}

Powered by Google App Engine
This is Rietveld 408576698