chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc - Issue 2518053002: Always delete media galleries FilePathWatchers on the FILE thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

Issue 2518053002: Always delete media galleries FilePathWatchers on the FILE thread. (Closed)

Patch Set: fix build error Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

diff --git a/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc b/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

index d46206796dc284c0b440b999ba251886d6368e00..4bd7be362a10c3759a95b54734482cd1d8a08443 100644

--- a/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

+++ b/chrome/browser/media_galleries/fileapi/picasa_data_provider_browsertest.cc

@@ -157,7 +157,7 @@ class TestPicasaDataProvider : public PicasaDataProvider {

private:

void OnTempDirWatchStarted(

- std::unique_ptr<base::FilePathWatcher> temp_dir_watcher) override {

+ MediaFilePathWatcherUniquePtr temp_dir_watcher) override {

PicasaDataProvider::OnTempDirWatchStarted(std::move(temp_dir_watcher));

file_watch_request_returned_ = true;

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa_data_provider.cc ('k') | no next file » | no next file with comments »