Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)
Patch Set: use set Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index 93ddc39f499aad20c992591a616a64f1a1e4e746..163214ad473cc0258b2da7adde529de6bbad2d48 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -492,12 +492,6 @@ void PasswordStore::GetLoginsWithAffiliationsImpl(
FillMatchingLogins({PasswordForm::SCHEME_HTML, realm, GURL()}));
for (auto& result : more_results)
result->is_affiliation_based_match = true;
- more_results.erase(
- std::remove_if(more_results.begin(), more_results.end(),
- [](const std::unique_ptr<PasswordForm>& result) {
- return !result->federation_origin.unique();
- }),
- more_results.end());
password_manager_util::TrimUsernameOnlyCredentials(&more_results);
const size_t results_count = results.size();
results.resize(results_count + more_results.size());

Powered by Google App Engine
This is Rietveld 408576698