Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)
Patch Set: use set Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index dfa3382c51d64fff26d2ebffb066f0ecaa2ae994..ac3a74e73e141c6fa2a57e25bcf8e462a014397b 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -480,8 +480,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {
"", "", L"", L"", L"",
L"username_value_4",
L"", true, 1},
- // Federated credential for this second Android application; this should
- // not be returned.
+ // Federated credential for this second Android application.
{PasswordForm::SCHEME_HTML,
kTestAndroidRealm2,
"", "", L"", L"", L"",
@@ -527,6 +526,8 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {
base::MakeUnique<PasswordForm>(*all_credentials[3]));
expected_results.push_back(
base::MakeUnique<PasswordForm>(*all_credentials[5]));
+ expected_results.push_back(
+ base::MakeUnique<PasswordForm>(*all_credentials[6]));
for (const auto& result : expected_results) {
if (result->signon_realm != observed_form.signon_realm &&
« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | ios/chrome/browser/passwords/credential_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698