components/password_manager/core/browser/password_store.h - Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)

Patch Set: use set Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_store.h

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h

index fa757c9f0e9298de18f94a77b7b277c275f32e19..d7998e40efd3f901b6c443f1eeba9abfeeb7efe8 100644

--- a/components/password_manager/core/browser/password_store.h

+++ b/components/password_manager/core/browser/password_store.h

@@ -167,9 +167,6 @@ class PasswordStore : protected PasswordStoreSync,

// Searches for a matching PasswordForm, and notifies |consumer| on

// completion. The request will be cancelled if the consumer is destroyed.

- // TODO(engedy): Currently, this will not return federated logins saved from

- // Android applications that are affiliated with the realm of |form|. Need to

- // decide if this is the desired behavior. See: https://crbug.com/539844.

virtual void GetLogins(const FormDigest& form,

PasswordStoreConsumer* consumer);