Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2517653002: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
tkent, eae
CC:
chromium-reviews, shans, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, rwlbuis, krit, drott+blinkwatch_chromium.org, blink-reviews-css, szager+layoutwatch_chromium.org, Justin Novosad, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, ajuma+watch_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, darktears, Stephen Chennney, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. This is an attempt to re-land a part of https://codereview.chromium.org/2419663009 BUG=641536 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=tkent Committed: https://crrev.com/da258e1713662615e9a3aab57501105b33883d0b Cr-Commit-Position: refs/heads/master@{#433320}

Patch Set 1 #

Patch Set 2 : Revert some of the changes which have a high risk of breaking things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/cfi/blacklist.txt View 1 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
krasin1
Hello Kent and Emil, this CL is a recreated https://codereview.chromium.org/2419663009/, but I have excluded some ...
4 years, 1 month ago (2016-11-18 18:47:50 UTC) #5
eae
LGTM
4 years, 1 month ago (2016-11-18 21:07:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517653002/20001
4 years, 1 month ago (2016-11-18 22:33:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 22:44:09 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 22:48:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da258e1713662615e9a3aab57501105b33883d0b
Cr-Commit-Position: refs/heads/master@{#433320}

Powered by Google App Engine
This is Rietveld 408576698