third_party/WebKit/Source/platform/graphics/ContiguousContainer.h - Issue 2517653002: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

Issue 2517653002: Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)

Patch Set: Revert some of the changes which have a high risk of breaking things Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

diff --git a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

index 38763c88e28efc26bb074c92dee0667f2fc5e3be..8932a64b2ee84390d2c1a770b93dd66487357246 100644

--- a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

+++ b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

@@ -5,6 +5,7 @@

#ifndef ContiguousContainer_h

#define ContiguousContainer_h

+#include "base/compiler_specific.h"

#include "platform/PlatformExport.h"

#include "wtf/Alignment.h"

#include "wtf/Allocator.h"

@@ -208,6 +209,7 @@ class ContiguousContainer : public ContiguousContainerBase {

ContiguousContainerBase::removeLast();

}

+ DISABLE_CFI_PERF

void clear() {

for (auto& element : *this) {

(void)element; // MSVC incorrectly reports this variable as unused.