Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific macros,
* a few entries point to more than one function (like traceImpl) and a regexp is justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fb1595d32aa4bfba0cb83698ef73af61fff6038f
Cr-Commit-Position: refs/heads/master@{#425607}

[krasin1, 2016-10-14 23:07:08]

Description was changed from

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:
some of the entries are disabled because of the known bugs in Chromium,
skia upstream considered to be not a suitable place for Chrome-specific macros,
a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
==========

to

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:
some of the entries are disabled because of the known bugs in Chromium,
skia upstream considered to be not a suitable place for Chrome-specific macros,
a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[krasin1, 2016-10-14 23:07:34]

Description was changed from

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:
some of the entries are disabled because of the known bugs in Chromium,
skia upstream considered to be not a suitable place for Chrome-specific macros,
a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific
macros,
* a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[krasin1, 2016-10-14 23:07:47]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 23:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-10-14 23:13:00]

The CQ bit was unchecked by krasin@chromium.org

[krasin1, 2016-10-15 00:37:32]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-10-15 00:52:55]

krasin@chromium.org changed reviewers:
+ eae@chromium.org

[eae, 2016-10-15 00:54:34]

LGTM for Source/core and Source/platform

[eae, 2016-10-15 00:55:10]

(I'm not an OWNER for Source/web so you'll need another reviewer for that)

[krasin1, 2016-10-15 00:55:47]

On 2016/10/15 00:55:10, eae wrote:
> (I'm not an OWNER for Source/web so you'll need another reviewer for that)

Thank you. I will find someone.

[krasin1, 2016-10-15 00:59:21]

krasin@chromium.org changed reviewers:
+ tkent@chromium.org

[krasin1, 2016-10-15 00:59:22]

Hello Kent,

can you please approve the change in
third_party/WebKit/Source/web/ChromeClientImpl.cpp (one liner)?

I do realize that it's Saturday in Japan already and this request is not urgent.
Please, review this CL on Monday.

[commit-bot: I haz the power, 2016-10-15 01:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 01:41:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2016-10-17 00:39:51]

lgtm

[krasin1, 2016-10-17 00:48:26]

On 2016/10/17 00:39:51, tkent wrote:
> lgtm

Thank you!

[krasin1, 2016-10-17 00:48:36]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-10-17 00:48:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 02:08:35]

Description was changed from

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific
macros,
* a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific
macros,
* a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-17 02:08:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 02:10:34]

Description was changed from

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific
macros,
* a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.

We're at ~90% of the blacklist converted, and the rest is hard:

* some of the entries are disabled because of the known bugs in Chromium,
* skia upstream considered to be not a suitable place for Chrome-specific
macros,
* a few entries point to more than one function (like traceImpl) and a regexp is
justified.

BUG=641536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fb1595d32aa4bfba0cb83698ef73af61fff6038f
Cr-Commit-Position: refs/heads/master@{#425607}
==========

[commit-bot: I haz the power, 2016-10-17 02:10:36]

Patchset 1 (id:??) landed as
https://crrev.com/fb1595d32aa4bfba0cb83698ef73af61fff6038f
Cr-Commit-Position: refs/heads/master@{#425607}

[krasin1, 2016-10-17 02:26:03]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2422973002/ by krasin@chromium.org.

The reason for reverting is: Possibly broke Chrome OS:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom....