Issue 2517213002: Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade()

Issue 2517213002: Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade() (Closed)

Created:
4 years, 1 month ago by pkotwicz

Modified:
4 years, 1 month ago

Reviewers:
dominickn

CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade() https://codereview.chromium.org/2453423002/ changed the scenario being tested. This CL makes #testManifestEmptyScopeShouldNotUpgrade() test the original scenario again. BUG=659845 Committed: https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6 Cr-Commit-Position: refs/heads/master@{#433790}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -41 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java	View		2 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java	View		4 chunks	+40 lines, -20 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517213002/20001

4 years, 1 month ago (2016-11-22 04:19:23 UTC) #6

commit-bot: I haz the power

4 years, 1 month ago (2016-11-22 04:51:21 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6
Cr-Commit-Position: refs/heads/master@{#433790}