Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1772)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java

Issue 2517213002: Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade() (Closed)
Patch Set: Merge branch 'master' into update_fail_refactor000 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
index 48d84ab8710d18d8a768823db3b03bd888cfb7a2..8549c3b3abbed71ef851cd43906c8a69ad672b32 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java
@@ -90,14 +90,13 @@ public class ManifestUpgradeDetectorFetcherTest extends ChromeTabbedActivityTest
/**
* Starts a ManifestUpgradeDetectorFetcher. Calls {@link callback} once the fetcher is done.
*/
- private void startManifestUpgradeDetectorFetcher(String scopeUrl, String manifestUrl,
- final ManifestUpgradeDetectorFetcher.Callback callback) {
- final ManifestUpgradeDetectorFetcher fetcher =
- new ManifestUpgradeDetectorFetcher(mTab, scopeUrl, manifestUrl);
+ private void startManifestUpgradeDetectorFetcher(final String scopeUrl,
+ final String manifestUrl, final ManifestUpgradeDetectorFetcher.Callback callback) {
+ final ManifestUpgradeDetectorFetcher fetcher = new ManifestUpgradeDetectorFetcher();
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- fetcher.start(callback);
+ fetcher.start(mTab, scopeUrl, manifestUrl, callback);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698