Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3742)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

Issue 2517213002: Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade() (Closed)
Patch Set: Merge branch 'master' into update_fail_refactor000 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
index e324b3e08f429b65436837cf94345d9f17947873..1420c9a641be72d061425d213bfac3592a4a3b1c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
@@ -80,17 +80,15 @@ public class ManifestUpgradeDetector implements ManifestUpgradeDetectorFetcher.C
return false;
}
- mFetcher = createFetcher(mTab, mMetaData.scope, mMetaData.manifestUrl);
- mFetcher.start(this);
- return true;
+ mFetcher = createFetcher();
+ return mFetcher.start(mTab, mMetaData.scope, mMetaData.manifestUrl, this);
}
/**
* Creates ManifestUpgradeDataFetcher.
*/
- protected ManifestUpgradeDetectorFetcher createFetcher(Tab tab, String scopeUrl,
- String manifestUrl) {
- return new ManifestUpgradeDetectorFetcher(tab, scopeUrl, manifestUrl);
+ protected ManifestUpgradeDetectorFetcher createFetcher() {
+ return new ManifestUpgradeDetectorFetcher();
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698