Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2517033002: Revert of Move WTF::SpinLock to base::SpinLock. (Closed)

Created:
4 years, 1 month ago by kapishnikov
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move WTF::SpinLock to base::SpinLock. (patchset #4 id:60001 of https://codereview.chromium.org/2484803003/ ) Reason for revert: Broke Android Cronet ARMv6 Builder: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/3565 Original issue's description: > Move WTF::SpinLock to base::SpinLock. > > This CL depends on https://codereview.chromium.org/2473153003 ("Move some > compiler intrinsic #defines to base/."). > > BUG=632441 > > Committed: https://crrev.com/d9dbd59434791ddc998d2aeb24f7f1326431ed14 > Cr-Commit-Position: refs/heads/master@{#433378} TBR=esprehn@chromium.org,dcheng@chromium.org,hans@chromium.org,thakis@chromium.org,primiano@chromium.org,palmer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632441 Committed: https://crrev.com/d0f9937ffbecc604e21893ee38f2385550daa8c5 Cr-Commit-Position: refs/heads/master@{#433472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -151 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
D base/synchronization/spin_lock.h View 1 chunk +0 lines, -52 lines 0 comments Download
D base/synchronization/spin_lock.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/SpinLock.h View 1 chunk +63 lines, -8 lines 0 comments Download
A third_party/WebKit/Source/wtf/SpinLock.cpp View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kapishnikov
Created Revert of Move WTF::SpinLock to base::SpinLock.
4 years, 1 month ago (2016-11-21 02:58:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517033002/1
4 years, 1 month ago (2016-11-21 02:58:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 04:29:03 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 04:32:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0f9937ffbecc604e21893ee38f2385550daa8c5
Cr-Commit-Position: refs/heads/master@{#433472}

Powered by Google App Engine
This is Rietveld 408576698