content/browser/devtools/devtools_manager_impl.h - Issue 251653003: Introduces DevToolsManagerDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_manager_impl.h

Issue 251653003: Introduces DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Register OpenDevToolsWindowForWorkerCallback to DevToolsManager Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_manager_impl.h

diff --git a/content/browser/devtools/devtools_manager_impl.h b/content/browser/devtools/devtools_manager_impl.h

index a14b2f1ca115b8616c3b33228113a5fa23b0668d..8a10e3225cbf300775aac002593816653ceaaf37 100644

--- a/content/browser/devtools/devtools_manager_impl.h

+++ b/content/browser/devtools/devtools_manager_impl.h

@@ -58,6 +58,10 @@ class CONTENT_EXPORT DevToolsManagerImpl

virtual void ClientHostClosing(DevToolsClientHost* host) OVERRIDE;

virtual void AddAgentStateCallback(const Callback& callback) OVERRIDE;

virtual void RemoveAgentStateCallback(const Callback& callback) OVERRIDE;

+ virtual void RegisterOpenDevToolsWindowForWorkerCallback(

+ const WindowOpenCallback& window_open_callback) OVERRIDE;

+ void OpenDevToolsWindowForWorker(BrowserContext*, DevToolsAgentHost*);

private:

friend class DevToolsAgentHostImpl;

@@ -96,6 +100,8 @@ class CONTENT_EXPORT DevToolsManagerImpl

typedef std::vector<const Callback*> CallbackContainer;

CallbackContainer callbacks_;

+ WindowOpenCallback open_window_for_worker_callback_;

DISALLOW_COPY_AND_ASSIGN(DevToolsManagerImpl);

};