Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: content/browser/devtools/devtools_manager_impl.cc

Issue 251653003: Introduces DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register OpenDevToolsWindowForWorkerCallback to DevToolsManager Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_impl.cc
diff --git a/content/browser/devtools/devtools_manager_impl.cc b/content/browser/devtools/devtools_manager_impl.cc
index 56b2dd7d2f420cd1830a9b9d6a431a4acd3bbe3b..b6ed0dd17b3ef74f4c2ecbd353331d7da5612873 100644
--- a/content/browser/devtools/devtools_manager_impl.cc
+++ b/content/browser/devtools/devtools_manager_impl.cc
@@ -181,6 +181,19 @@ void DevToolsManagerImpl::RemoveAgentStateCallback(const Callback& callback) {
callbacks_.erase(it);
}
+void DevToolsManagerImpl::RegisterOpenDevToolsWindowForWorkerCallback(
+ const WindowOpenCallback& window_open_callback) {
+ open_window_for_worker_callback_ = window_open_callback;
+}
+
+void DevToolsManagerImpl::OpenDevToolsWindowForWorker(
+ BrowserContext* browser_context,
+ DevToolsAgentHost* agent_host) {
+ if (open_window_for_worker_callback_.is_null())
+ return;
+ open_window_for_worker_callback_.Run(browser_context, agent_host);
+}
+
void DevToolsManagerImpl::NotifyObservers(DevToolsAgentHost* agent_host,
bool attached) {
CallbackContainer copy(callbacks_);

Powered by Google App Engine
This is Rietveld 408576698