Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5085)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 251653003: Introduces DevToolsManagerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register OpenDevToolsWindowForWorkerCallback to DevToolsManager Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index e1e627db85884f65e6b9024dcce930c161411c59..0463a5e16bef1f1ac85994e208d55a3e33c16c9c 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -67,6 +67,13 @@ base::LazyInstance<DevToolsWindows>::Leaky g_instances =
static const char kKeyUpEventName[] = "keyup";
static const char kKeyDownEventName[] = "keydown";
+void OpenDevToolsWindowForWorkerWithBrowserContext(
+ content::BrowserContext* browser_context,
+ DevToolsAgentHost* worker_agent) {
+ DevToolsWindow::OpenDevToolsWindowForWorker(
+ Profile::FromBrowserContext(browser_context), worker_agent);
+}
+
} // namespace
// DevToolsEventForwarder -----------------------------------------------------
@@ -313,6 +320,12 @@ DevToolsWindow* DevToolsWindow::OpenDevToolsWindowForWorker(
}
// static
+content::DevToolsManager::WindowOpenCallback
+DevToolsWindow::GetOpenDevToolsWindowForWorkerCallback() {
+ return base::Bind(&OpenDevToolsWindowForWorkerWithBrowserContext);
+}
+
+// static
DevToolsWindow* DevToolsWindow::CreateDevToolsWindowForWorker(
Profile* profile) {
content::RecordAction(base::UserMetricsAction("DevTools_InspectWorker"));

Powered by Google App Engine
This is Rietveld 408576698